Skip to content

core-utils: parse L1 timestamp in injectContext#1607

Merged
tynes merged 1 commit intodevelopfrom
fix/parse-l1-timestamp
Oct 21, 2021
Merged

core-utils: parse L1 timestamp in injectContext#1607
tynes merged 1 commit intodevelopfrom
fix/parse-l1-timestamp

Conversation

@tynes
Copy link
Copy Markdown
Contributor

@tynes tynes commented Oct 20, 2021

Description

Also parse the L1 timestamp in injectContext.
This value is useful but was not previously parsed
and added to the ethers provider

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 20, 2021

🦋 Changeset detected

Latest commit: 2e929aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/core-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Oct 20, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #1607 (2e929aa) into develop (e87f2b3) will decrease coverage by 0.19%.
The diff coverage is 10.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1607      +/-   ##
===========================================
- Coverage    76.71%   76.52%   -0.20%     
===========================================
  Files           82       82              
  Lines         3032     3041       +9     
  Branches       463      466       +3     
===========================================
+ Hits          2326     2327       +1     
- Misses         706      714       +8     
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 86.05% <ø> (ø)
core-utils 63.27% <10.00%> (-1.77%) ⬇️
data-transport-layer 37.86% <ø> (ø)
message-relayer 83.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-utils/src/l2context.ts 7.31% <10.00%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87f2b3...2e929aa. Read the comment docs.

@tynes tynes force-pushed the fix/parse-l1-timestamp branch from f745c40 to c3fcf15 Compare October 20, 2021 13:36
Also parse the L1 timestamp in `injectContext`.
This value is useful but was not previously parsed
and added to the ethers provider
@tynes tynes force-pushed the fix/parse-l1-timestamp branch from c3fcf15 to 2e929aa Compare October 20, 2021 16:18
@tynes tynes merged commit fc0616e into develop Oct 21, 2021
@tynes tynes deleted the fix/parse-l1-timestamp branch October 21, 2021 20:37
theochap pushed a commit that referenced this pull request Dec 10, 2025
Co-authored-by: clabby <8406232+clabby@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants