all: Add Interop rollup config set to op-supervisor#16038
Merged
sebastianst merged 3 commits intodevelopfrom May 22, 2025
Merged
all: Add Interop rollup config set to op-supervisor#16038sebastianst merged 3 commits intodevelopfrom
sebastianst merged 3 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #16038 +/- ##
============================================
+ Coverage 46.98% 87.52% +40.53%
============================================
Files 1360 20 -1340
Lines 109447 1707 -107740
============================================
- Hits 51429 1494 -49935
+ Misses 54369 193 -54176
+ Partials 3649 20 -3629
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
82e330f to
9676c92
Compare
9676c92 to
37efba7
Compare
sebastianst
commented
May 22, 2025
cc3f2da to
dc7a668
Compare
protolambda
reviewed
May 22, 2025
Contributor
protolambda
left a comment
There was a problem hiding this comment.
Uncertain if we can merge this; kurtosis interop CI will break. We will need to work with platforms to get that updated
9b6edc5 to
536d2e9
Compare
22e1736 to
3a77926
Compare
protolambda
approved these changes
May 22, 2025
3a77926 to
5076a14
Compare
janjakubnanista
pushed a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 22, 2025
ethereum-optimism/optimism#16038 introduces a new required command line flag/env var `OP_SUPERVISOR_ROLLUP_CONFIG_PATHS`.
5076a14 to
44744c1
Compare
janjakubnanista
pushed a commit
to ethpandaops/optimism-package
that referenced
this pull request
May 22, 2025
ethereum-optimism/optimism#16038 introduces a new required command line flag/env var `OP_SUPERVISOR_ROLLUP_CONFIG_PATHS`.
7ce1497 to
3ea8c9d
Compare
protolambda
approved these changes
May 22, 2025
370c71b to
f9e782c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new rollup config set as an additional configuration requirement to the op-supervisor. It's a set of trimmed-down versions of the classic
rollup.Config, just containing the configuration fields relevant to the supervisor. It needs to be provided in addition to the Interop dependency set. It also adds a bit more information, namely the timestamp of the genesis L1 block.I've created a merged configuration interface
depset.FullConfigSetthat combined both, the dep set and rollup config set into one, to easer pass the config around when setting up the supervisor.It may make sense to rename the
op-supervisor/supervisor/backend/depsetpackage to something likeop-supervisor/supervisor/backend/config, or maybe move it a bit higher up, likeop-supervisor/supervisor/config.Tests
Adapted existing testes. There may be a few tests missing, which I'm happy to add.
Additional context
This is in preparation for the upgrade work at #16008 where the rollup config is needed.
Metadata