Skip to content

feat: batch-submitter peripheral resources#1576

Merged
tynes merged 3 commits intoethereum-optimism:developfrom
cfromknecht:bss-resources
Oct 14, 2021
Merged

feat: batch-submitter peripheral resources#1576
tynes merged 3 commits intoethereum-optimism:developfrom
cfromknecht:bss-resources

Conversation

@cfromknecht
Copy link
Copy Markdown
Contributor

Description
This PR adds the primary resources that will be used by the batch submitter service(s). This includes:

  • L1 and L2 provider connections
  • Sequencer wallet private key derivation and CTC address parsing
  • Proposer wallet private key derivation and SCC address parsing
  • Prometheus metrics server
  • Sentry error logging

For Sentry Logging, the current approach creates a custom log.Handler that mimics the default log.StreamHandler. Internally, this writes to os.Stdout, and then writes anything greater than or equal to log.LvlError to Sentry. With this approach, we are also able to capture additional logging context by serializing the log.Record using geth's JSONFormat, and including the JSON blob as extra data to Sentry.

Specific prometheus metrics will be added as the sub-services are built.

Metadata

  • Fixes ENG-1480

Creates a custom SentryStremHandler that functions analgously to a
log.StreamHandler, with the exception that any LvlError logs or higher
are posted to Sentry. It also leverages the existing go-ethereum logging
formatters, specifically JSONFormat, to post any additional log context
items as a JSON blob via extra data.
Adds logic to parse private key strings from a string (for debug
purposes) or from a valid BIP39 mnemonic and valid BIP32 derivation
path.

Additionally adds a ParseAddress helper to ensure proper parsing and
sanitization of contract addresses.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 14, 2021

⚠️ No Changeset found

Latest commit: c6ccc9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Adds the main BatchSubmitter service struct that will provide resources
to the (yet to be implemented) TxBatchSubmitter and StateBatchSubmitter
sub-services. This root service also sets up Sentry logging and
the embedded Prometheus metrics server.
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1576 (c6ccc9e) into develop (28a2e5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1576   +/-   ##
========================================
  Coverage    76.71%   76.71%           
========================================
  Files           82       82           
  Lines         3032     3032           
  Branches       463      463           
========================================
  Hits          2326     2326           
  Misses         706      706           
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 86.05% <ø> (ø)
core-utils 65.03% <ø> (ø)
data-transport-layer 37.86% <ø> (ø)
message-relayer 83.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a2e5d...c6ccc9e. Read the comment docs.

@tynes tynes merged commit e87f2b3 into ethereum-optimism:develop Oct 14, 2021
@cfromknecht cfromknecht deleted the bss-resources branch October 14, 2021 20:31
theochap pushed a commit that referenced this pull request Dec 10, 2025
### Description

Implements the `opp2p_disconnectPeer` rpc request.

Closes #1576
theochap pushed a commit that referenced this pull request Jan 14, 2026
### Description

Implements the `opp2p_disconnectPeer` rpc request.

Closes #1576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants