gas-oracle: use configured gas-price#1574
Conversation
Use the configured gas price when updating the L1 base fee. In production, this should be set to 0 and the sequencer will allow for transactions with 0 gas price when they are from the owner of the gas price oracle. This prevents the need to manage funds on L2 for the `gas-oracle`
🦋 Changeset detectedLatest commit: 1fb36a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## experimental #1574 +/- ##
================================================
- Coverage 74.20% 73.62% -0.58%
================================================
Files 67 67
Lines 2210 2207 -3
Branches 321 324 +3
================================================
- Hits 1640 1625 -15
- Misses 570 582 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
karlfloersch
left a comment
There was a problem hiding this comment.
My understanding is that by setting opts.GasPrice explicitly it will not default to generating EIP1559 txs -- a tx type we do not currently support.
LGTM!
Description
Use the configured gas price when updating the L1 base fee.
In production, this should be set to 0 and the sequencer
will allow for transactions with 0 gas price when they are
from the owner of the gas price oracle. This prevents the
need to manage funds on L2 for the
gas-oracleFixes ENG-1487