Skip to content

fix: linting#1567

Merged
tynes merged 1 commit intodevelopfrom
linty-lint
Oct 13, 2021
Merged

fix: linting#1567
tynes merged 1 commit intodevelopfrom
linty-lint

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Oct 13, 2021 •
edited
Loading

Noticed some linter warnings on #1566, fixing here rather than blocking that PR.

Presumably this is caused by some small changes to the prettier rules in the updated version.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 13, 2021

⚠️ No Changeset found

Latest commit: 3257711

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maurelian maurelian requested a review from snario October 13, 2021 14:20
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #1567 (3257711) into develop (02d4670) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1567   +/-   ##
========================================
  Coverage    76.71%   76.71%           
========================================
  Files           82       82           
  Lines         3032     3032           
  Branches       463      463           
========================================
  Hits          2326     2326           
  Misses         706      706
Flag Coverage Δ
batch-submitter 61.74% <ø> (ø)
contracts 86.05% <ø> (ø)
core-utils 65.03% <ø> (ø)
data-transport-layer 37.86% <ø> (ø)
message-relayer 83.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d4670...3257711. Read the comment docs.

@tynes tynes merged commit 66fc726 into develop Oct 13, 2021
@tynes tynes deleted the linty-lint branch October 13, 2021 15:09
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat(std-fpvm): Instruct kernel to lazily allocate pages (#1567)
d07db05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@snario snario Awaiting requested review from snario

Assignees

No one assigned

Labels

A-op-batcher Area: op-batcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelian @codecov-commenter @tynes