Merged
Conversation
* feat: add mul access lists test * chore: polish * chore: pre pr * feat: add more tests * feat: wip to add more tests * fix: multiple msgs tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15465 +/- ##
===========================================
- Coverage 46.51% 45.40% -1.11%
===========================================
Files 1254 1195 -59
Lines 104325 99588 -4737
===========================================
- Hits 48527 45219 -3308
+ Misses 52373 51117 -1256
+ Partials 3425 3252 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Apr 18, 2025
tynes
approved these changes
May 2, 2025
| validateMessageRelayer.validateAndRetry(_id, _messageHash); | ||
| } | ||
|
|
||
| /// Test that multiple calls to `validateMessage` with multiple storage keys succeeds on the same tx succeeds. |
Contributor
There was a problem hiding this comment.
There's a redundant "succeeds" in the function comment. It should read "Test that multiple calls to validateMessage with multiple storage keys on the same tx succeeds" to avoid repetition and improve clarity.
Suggested change
| /// Test that multiple calls to `validateMessage` with multiple storage keys succeeds on the same tx succeeds. | |
| /// Test that multiple calls to `validateMessage` with multiple storage keys on the same tx succeeds. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
iquidus
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jul 24, 2025
* feat: add mul access lists test (ethereum-optimism#370) * feat: add mul access lists test * chore: polish * chore: pre pr * feat: add more tests * feat: wip to add more tests * fix: multiple msgs tests * fix: semgrep (ethereum-optimism#371) --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
CrossL2Inbox's multiple access list tests to complete FMA actions items.Additional context
Interop access list FMA: ethereum-optimism/design-docs#252
Authored by @0xDiscotech