Skip to content

feat(kurtosis-devnet): use contracts artifacts#14932

Merged
scharissis merged 1 commit intodevelopfrom
sigma/contracts-artifacts
Apr 15, 2025
Merged

feat(kurtosis-devnet): use contracts artifacts#14932
scharissis merged 1 commit intodevelopfrom
sigma/contracts-artifacts

Conversation

@sigma
Copy link
Copy Markdown
Contributor

@sigma sigma commented Mar 18, 2025

Description

This changes the way that local contracts are integrated into a kurtosis devnet.

The new flow works by optionally creating the enclave artifact ahead of time (and skipping that step if the right artifact already exists), and pointing op-deployer to it.
In particular, it's much more lightweight if contracts don't change between redeployments.

Tests

Additional context

Metadata

This is part of #14390

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 50.57915% with 128 lines in your changes missing coverage. Please review.

Project coverage is 42.46%. Comparing base (11ace4c) to head (7d3e39f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
kurtosis-devnet/pkg/build/contracts.go 48.25% 72 Missing and 32 partials ⚠️
kurtosis-devnet/pkg/kurtosis/api/fake/fake.go 0.00% 9 Missing ⚠️
...urtosis-devnet/pkg/kurtosis/api/enclave/enclave.go 80.64% 5 Missing and 1 partial ⚠️
kurtosis-devnet/pkg/build/docker.go 0.00% 4 Missing ⚠️
...rtosis-devnet/pkg/kurtosis/api/run/kurtosis_run.go 50.00% 3 Missing and 1 partial ⚠️
kurtosis-devnet/pkg/deploy/template.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14932      +/-   ##
===========================================
- Coverage    46.48%   42.46%   -4.03%     
===========================================
  Files         1250     1079     -171     
  Lines       103813    93776   -10037     
===========================================
- Hits         48262    39825    -8437     
+ Misses       52159    50709    -1450     
+ Partials      3392     3242     -150     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
kurtosis-devnet/pkg/deploy/template.go 81.11% <83.33%> (-0.52%) ⬇️
kurtosis-devnet/pkg/build/docker.go 28.27% <0.00%> (-38.40%) ⬇️
...rtosis-devnet/pkg/kurtosis/api/run/kurtosis_run.go 51.08% <50.00%> (-4.24%) ⬇️
...urtosis-devnet/pkg/kurtosis/api/enclave/enclave.go 80.64% <80.64%> (ø)
kurtosis-devnet/pkg/kurtosis/api/fake/fake.go 86.07% <0.00%> (-6.79%) ⬇️
kurtosis-devnet/pkg/build/contracts.go 52.60% <48.25%> (+48.90%) ⬆️

... and 180 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sigma sigma force-pushed the sigma/contracts-artifacts branch from c56a0d3 to 3a6b0c9 Compare March 24, 2025 18:04
@sigma sigma changed the base branch from develop to sigma/kt-afero March 24, 2025 18:05
@sigma sigma force-pushed the sigma/contracts-artifacts branch 4 times, most recently from c94d1a7 to 35cbb7a Compare March 24, 2025 18:30
Base automatically changed from sigma/kt-afero to develop March 25, 2025 09:53
@sigma sigma force-pushed the sigma/contracts-artifacts branch from 35cbb7a to 57a20d4 Compare March 25, 2025 10:19
@sigma sigma marked this pull request as ready for review March 25, 2025 10:23
@sigma sigma requested a review from a team as a code owner March 25, 2025 10:23
@sigma sigma requested a review from tynes March 25, 2025 10:23
@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Apr 8, 2025
@opgitgovernance
Copy link
Copy Markdown
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

@sigma sigma force-pushed the sigma/contracts-artifacts branch from 57a20d4 to 9657bdf Compare April 15, 2025 08:10
@sigma sigma force-pushed the sigma/contracts-artifacts branch from 9657bdf to 7d3e39f Compare April 15, 2025 08:11
@scharissis scharissis enabled auto-merge April 15, 2025 08:45
@scharissis
Copy link
Copy Markdown
Contributor

Adding to merge queue to unblock @josepmc

@scharissis scharissis added this pull request to the merge queue Apr 15, 2025
Merged via the queue into develop with commit 035457b Apr 15, 2025
49 checks passed
@scharissis scharissis deleted the sigma/contracts-artifacts branch April 15, 2025 08:58
iquidus pushed a commit to Layr-Labs/optimism that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale Status: Will be closed unless there is activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants