[added] coverage for getMerkleTreeProof#1470
Conversation
🦋 Changeset detectedLatest commit: e504bb4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1470 +/- ##
===========================================
+ Coverage 76.47% 76.87% +0.40%
===========================================
Files 81 81
Lines 3018 3019 +1
Branches 463 463
===========================================
+ Hits 2308 2321 +13
+ Misses 710 698 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
How exactly did you generate the test vectors? If you copied them from the output of calling the function, it only really checks that the functionality doesn't change in the future. I wonder if there are standard test vectors used elsewhere in the ethereum ecosystem that we can use here |
Yep just got them from the output of the function (definitely hard to reason about just from looking at inputs and outputs). Will definitely look for standard test vectors. |
|
If there isn't anything obviously out there then this PR is fine to merge as is |
|
not seeing anything super obvious from google searches but will definitely submit a new PR if I am able to find something 😄 |
|
Thank you for this PR! |
Description
getMerkleTreeProoffunction inpackages/message-relayer/relay-tx.tsAdditional context
Additional coverage increases total
message-relayerpackage coverage from ~72% to 83%Metadata