feat: introduce eth lockbox#14588
Merged
smartcontracts merged 39 commits intoethereum-optimism:feat/interop-portal-updatesfrom Mar 8, 2025
Merged
feat: introduce eth lockbox#14588smartcontracts merged 39 commits intoethereum-optimism:feat/interop-portal-updatesfrom
smartcontracts merged 39 commits intoethereum-optimism:feat/interop-portal-updatesfrom
Conversation
Updates the OptimismPortal to use the AnchorStateRegistry as the source of truth for the validity of Dispute Game contracts.
* feat: create new eth lockbox contract with interface * chore: add it on the deployment scripts (wip) * feat: create the test base to check if the setup for it is working * feat: add all eth lockbox tests * fix: opcm deployment script issue * fix: lockbox tests * feat: add no withdrawal tx unlock eth check * chore: check proper initialization on test * fix: pre-pr fixes * chore: run pre-pr * fix: opcm tests related to eth lockbox * feat: add admin owner check on authorize portal and lockbox as well * refactor: add prefix to errors and declare them on contract * chore add no withdrawal tx comment * feat: authorize portal in lockbox on the opcm * chore: add one more check for eth lockbox * fix: intializable and specs tests * fix: pre-pr
* feat: integrate portal with lockbox * fix: migrate natspec Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * fix: delete natspec Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com> * fix: natspec nits * chore: natspec wording * chore: function order * chore: remove internals * feat: add eth lockbox as portal arg on opcm * feat: add checks on scripts and unit tests * feat: lock and unlock tests * feat: add migrate liquidity tests * fix: other failing portal tests * chore: run pre-pr * chore: improve lock and unlock checks on tests * chore: undo portal version change and run pre-pr * refactor: enhance expect call checks * fix: fork test string error * fix: just test failing tests * refactor: pao base * refactor: setup portal and lockbox integration on initialization * feat: update lockbox setter * chore: update pao naming on tests * chore: portal comment * chore: update version and run pre-pr * fix: spec * fix: lockbox storage layout * fix: pr comments and failing test * feat: portal upgrade test * chore: remove portal balance check on chain assertions * fix: error string on chain assertions * feat: add test for portal unsafe target * fix: approval --------- Co-authored-by: Disco <131301107+0xDiscotech@users.noreply.github.com>
Contributor
|
/ci authorize a381511 |
Contributor
|
/ci authorize 878d2a9 |
tynes
reviewed
Mar 1, 2025
tynes
reviewed
Mar 1, 2025
tynes
reviewed
Mar 1, 2025
* chore: remove unused function * chore: add pao validation checks over portal and lockbox * refactor: use interface as arg type instead of address on functions * fix: comment max length * refactor: update lockbox param type as interface * refactor: use interface as type on migrate liquidity and authorize lockbox functions * chore: run pre pr * fix: high fuzz runs failing test using mostly assume not forge address * refactor: use ioptimis portal instead of ioptimism portal2 everywhere * chore: undo changes on unrelated files to the pr
Updates the OptimismPortal to include a method that allows users to prove against Super Roots for interop.
* chore: undo initializable v5 test changes * chore: remove portal already authorized check * chore: remove portal already authorized check * refactor: rename pao to proxy admin owner
…pwd-super-roots feat: add Super Root specific method to OptimismPortal
…nto fix/sync-feature-branch
fix: sync feature branch
* fix: test upgrade fails * feat: handle fork state on eth lockbox tests * chore: enhance comments * chore: run pre-pr * fix: semgrep * fix: comments * chore: address path where is not a fork to get the lockbox * chore: run pre pr
Contributor
smartcontracts
left a comment
There was a problem hiding this comment.
Broadly looking quite good, pending CI
…e number (#303) * fix: include lockbox on reinitialization test * fix: polish nits * refactor: get eth lockbox on test condition * chore: add todos pointing to the issue
Contributor
|
/ci authorize 859810a |
Contributor
|
/ci authorize 23f5395 |
Contributor
|
/ci authorize 151b18f |
Contributor
|
/ci authorize 5c59150 |
Contributor
|
/ci authorize 5311c21 |
Contributor
|
/ci authorize b1b6ecc |
Contributor
|
/ci authorize 8f150df |
Contributor
|
/ci authorize 93c578d |
Contributor
|
/ci authorize ae4dfad |
maurelian
reviewed
Mar 7, 2025
maurelian
reviewed
Mar 7, 2025
maurelian
reviewed
Mar 7, 2025
maurelian
reviewed
Mar 7, 2025
maurelian
reviewed
Mar 7, 2025
mslipper
approved these changes
Mar 7, 2025
* chore: remove unnecessary cast * refactor: add lockbox on eth migrated event * chore: rename pa owner to pa owned base * refactor: add amount on liquidity received and migrated events * fix: format * refactor: add amount on liquidity migrated event * chore: pre-pr --------- Co-authored-by: agusduha <agusnduha@gmail.com>
Contributor
|
/ci authorize 3f59cf0 |
maurelian
approved these changes
Mar 7, 2025
7a771e6
into
ethereum-optimism:feat/interop-portal-updates
45 of 47 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introducing the
ETHLockboxcontract to improve the Superchain’s interoperable ETH withdrawal user experience, preventing withdrawal failures caused by insufficient ETH in theOptimismPortal.Design doc: ethereum-optimism/design-docs#206
Spec: ethereum-optimism/specs#465