feat: ETH lockbox redesign#206
Merged
smartcontracts merged 4 commits intoethereum-optimism:mainfrom Feb 25, 2025
Merged
Conversation
maurelian
reviewed
Feb 20, 2025
maurelian
reviewed
Feb 20, 2025
maurelian
reviewed
Feb 20, 2025
maurelian
reviewed
Feb 20, 2025
maurelian
reviewed
Feb 20, 2025
maurelian
reviewed
Feb 20, 2025
mds1
reviewed
Feb 20, 2025
ControlCplusControlV
approved these changes
Feb 21, 2025
Contributor
ControlCplusControlV
left a comment
There was a problem hiding this comment.
Looks good to me, but would appreciate some more specificity on how the lockboxes should should be treated after migration
smartcontracts
approved these changes
Feb 21, 2025
Contributor
smartcontracts
left a comment
There was a problem hiding this comment.
LGTM with some very minor comments
Contributor
|
Ok just waiting on approval from @mds1 now |
mds1
reviewed
Feb 22, 2025
mds1
reviewed
Feb 22, 2025
mds1
approved these changes
Feb 22, 2025
mds1
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making changes to the current ETH lockbox design doc to apply the new design changes. The dependency set is removed from L1 and the
SuperchainConfigis no more related with the lockbox. Every portal will migrate to have its own lockbox and later two lockboxes can be merged. We use the "upgrader controller" as the authorized role instead of the system admin to be coordinated with the new OPCM design.