op-dispute-mon: Update credit monitoring to handle new withdrawal path#14496
Merged
op-dispute-mon: Update credit monitoring to handle new withdrawal path#14496
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14496 +/- ##
============================================
- Coverage 46.48% 15.26% -31.23%
============================================
Files 1018 8 -1010
Lines 87912 688 -87224
============================================
- Hits 40865 105 -40760
+ Misses 44003 571 -43432
+ Partials 3044 12 -3032
Flags with carried forward coverage won't be shown. Click here to find out more. |
Inphi
approved these changes
Feb 24, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
ethereum-optimism#14496) * op-dispute-mon: Load bond distribution mode. * op-dispute-mon: Update credit monitoring to handle new withdrawal path. * Simplify
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates op-dispute-mon to handle the new withdrawal path for bonds. The withdrawal request isn't created in
DelayedWETHuntil the game is closed so if the game is in undecided bond distribution mode, all withdrawal requests should be 0 (previously this alerted because it differs from the game credits). In normal or refund mode, it should either be 0 (haven't yet called claimCredit to start the withdrawal process) or matching the credit. Older versions of contracts report bond distribution mode asLegacyDistributionModeand the old rules still apply.Also added some utility methods for comparing big ints because I'm sick of having to stop and think what the long
.Cmpinvocation actually means.Tests
Updated unit tests.
Metadata
Fixes #14448