devnet-sdk: add name to descriptors.DevnetEnvironment struct#14492
Merged
scharissis merged 1 commit intodevelopfrom Feb 23, 2025
Merged
devnet-sdk: add name to descriptors.DevnetEnvironment struct#14492scharissis merged 1 commit intodevelopfrom
scharissis merged 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14492 +/- ##
============================================
- Coverage 78.18% 15.26% -62.93%
============================================
Files 178 8 -170
Lines 10667 688 -9979
============================================
- Hits 8340 105 -8235
+ Misses 2137 571 -1566
+ Partials 190 12 -178
Flags with carried forward coverage won't be shown. Click here to find out more. |
scharissis
approved these changes
Feb 23, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a top level name field to the existing struct