Skip to content

test(devnet-sdk): check file URLs work as intended#14476

Merged
sigma merged 1 commit intodevelopfrom
sigma/devnet-sdk-file-fetcher
Feb 21, 2025
Merged

test(devnet-sdk): check file URLs work as intended#14476
sigma merged 1 commit intodevelopfrom
sigma/devnet-sdk-file-fetcher

Conversation

@sigma
Copy link
Copy Markdown
Contributor

@sigma sigma commented Feb 20, 2025

Description

Add tests for the environment file-based fetcher.

Tests

Additional context

Metadata

@sigma sigma requested a review from a team as a code owner February 20, 2025 22:10
@sigma sigma requested a review from bitwiseguy February 20, 2025 22:10
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.26%. Comparing base (ca980a3) to head (a3d3c08).
Report is 27 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (ca980a3) and HEAD (a3d3c08). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (ca980a3) HEAD (a3d3c08)
2 1
cannon-go-tests-32 1 0
cannon-go-tests-64 1 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14476       +/-   ##
============================================
- Coverage    46.18%   15.26%   -30.93%     
============================================
  Files         1014        8     -1006     
  Lines        87347      688    -86659     
============================================
- Hits         40344      105    -40239     
+ Misses       43987      571    -43416     
+ Partials      3016       12     -3004     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1014 files with indirect coverage changes

@sigma sigma added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit fac6b34 Feb 21, 2025
46 checks passed
@sigma sigma deleted the sigma/devnet-sdk-file-fetcher branch February 21, 2025 08:50
Rjected pushed a commit to paradigmxyz/optimism that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants