op-service: cleanup rw map utils#14474
Merged
protolambda merged 2 commits intodevelopfrom Feb 21, 2025
Merged
Conversation
axelKingsley
approved these changes
Feb 21, 2025
Co-authored-by: Axel Kingsley <axel.kingsley@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14474 +/- ##
============================================
- Coverage 77.23% 15.26% -61.98%
============================================
Files 178 8 -170
Lines 10667 688 -9979
============================================
- Hits 8239 105 -8134
+ Misses 2247 571 -1676
+ Partials 181 12 -169
Flags with carried forward coverage won't be shown. Click here to find out more. |
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
* op-service: cleanup rw map utils * op-service: fix doc comment Co-authored-by: Axel Kingsley <axel.kingsley@gmail.com> --------- Co-authored-by: Axel Kingsley <axel.kingsley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up the RWMap utils:
DefaulttoCreateIfMissingSetIfMissingInitPtrMaybe, which the above funcs do better anywayRWMapFromMapTests
Covered new functions + added some checks for previously missing things.
Additional context
Need these funcs for other PRs