Skip to content

fix(kurtosis-devnet): restore TestSmokeTestFailure#14465

Merged
sigma merged 1 commit intodevelopfrom
sigma/kt-negative-test
Feb 21, 2025
Merged

fix(kurtosis-devnet): restore TestSmokeTestFailure#14465
sigma merged 1 commit intodevelopfrom
sigma/kt-negative-test

Conversation

@sigma
Copy link
Copy Markdown
Contributor

@sigma sigma commented Feb 20, 2025

Description

In a previous refactoring we temporary lost the ability to run this
negative test on the smoke test scenario.
This change restores it.

Tests

Additional context

Metadata

@sigma sigma requested a review from a team as a code owner February 20, 2025 19:24
@sigma sigma requested a review from mslipper February 20, 2025 19:24
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.26%. Comparing base (fac6b34) to head (05ed840).
Report is 1 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (fac6b34) and HEAD (05ed840). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (fac6b34) HEAD (05ed840)
2 1
cannon-go-tests-32 2 0
cannon-go-tests-64 2 0
contracts-bedrock-tests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14465       +/-   ##
============================================
- Coverage    78.11%   15.26%   -62.86%     
============================================
  Files          178        8      -170     
  Lines        10667      688     -9979     
============================================
- Hits          8333      105     -8228     
+ Misses        2143      571     -1572     
+ Partials       191       12      -179     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

In a previous refactoring we temporary lost the ability to run this
negative test on the smoke test scenario.
This change restores it.
@sigma sigma force-pushed the sigma/kt-negative-test branch from d871314 to 05ed840 Compare February 21, 2025 15:06
@sigma sigma enabled auto-merge February 21, 2025 15:06
@sigma sigma added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit c0d2121 Feb 21, 2025
46 checks passed
@sigma sigma deleted the sigma/kt-negative-test branch February 21, 2025 15:19
Rjected pushed a commit to paradigmxyz/optimism that referenced this pull request Feb 25, 2025
…#14465)

In a previous refactoring we temporary lost the ability to run this
negative test on the smoke test scenario.
This change restores it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants