chore(devnet-sdk): move kurtosis artifact fs to devnet-sdk#14461
Merged
chore(devnet-sdk): move kurtosis artifact fs to devnet-sdk#14461
Conversation
This change makes devnet-sdk a leaf package as far as the rest of the monorepo is concerned. The artifact package was never really specific to kurtosis-devnet anyway, as it contains a generic filesystem abstraction to access kurtosis enclave artifacts. So we might as well add it to the rest of kurtosis helper functions in devnet-sdk. Going forward we'll likely want to split it into a separate module, so that other repositories can import it without needing to import the whole monorepo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14461 +/- ##
============================================
- Coverage 46.18% 15.26% -30.93%
============================================
Files 1014 8 -1006
Lines 87347 688 -86659
============================================
- Hits 40344 105 -40239
+ Misses 43987 571 -43416
+ Partials 3016 12 -3004
Flags with carried forward coverage won't be shown. Click here to find out more. |
janjakubnanista
approved these changes
Feb 20, 2025
zhwrd
approved these changes
Feb 20, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
…optimism#14461) This change makes devnet-sdk a leaf package as far as the rest of the monorepo is concerned. The artifact package was never really specific to kurtosis-devnet anyway, as it contains a generic filesystem abstraction to access kurtosis enclave artifacts. So we might as well add it to the rest of kurtosis helper functions in devnet-sdk. Going forward we'll likely want to split it into a separate module, so that other repositories can import it without needing to import the whole monorepo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes devnet-sdk a leaf package as far as the rest of the
monorepo is concerned.
The artifact package was never really specific to kurtosis-devnet
anyway, as it contains a generic filesystem abstraction to access
kurtosis enclave artifacts. So we might as well add it to the rest of
kurtosis helper functions in devnet-sdk.
Going forward we'll likely want to split it into a separate module, so
that other repositories can import it without needing to import the
whole monorepo.
Tests
Additional context
Metadata