🦋 Changeset detected

Latest commit: 7f7f35c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Nice. For some context, we used to use this as our L1 and L2 deployment script but have since moved to using hardhat-deploy for L1. Super useful PR!

@smartcontracts thanks for your help! You made this PR super easy. I noticed that there are 3 workflows awaiting approval, do you need anything from me to get those done?

Hey @spiyer99, could you add a patch changeset for the contracts package using yarn changeset and squash the commits into a single commit that looks like contracts: remove l1 contracts from l2 state dump process

Codecov Report

Merging #1445 (2e7d783) into develop (b08d725) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1445   +/-   ##
========================================
  Coverage    76.47%   76.47%           
========================================
  Files           81       81           
  Lines         3018     3018           
  Branches       463      463           
========================================
  Hits          2308     2308           
  Misses         710      710           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08d725...2e7d783. Read the comment docs.

Sure @tynes, will do. I'll reply here when I'm done.

@tynes, I added a patch changeset for the contracts package and squashed the commits into a single commit using the message you specified earlier. Hopefully I've done this correctly. Happy to change things if I've messed up somewhere.

Looking good! Could you just rebase this on top of the latest version of develop and then mark it as ready for review?

git fetch followed by git rebase origin/develop or git rebase -i origin/develop (if you want an interactive rebase)

Thanks for the help @smartcontracts!

Hey! Sorry for the delay here. Would you mind rebasing one more time so we can get this baby merged? Thank you!

@smartcontracts just rebased it. Let me know if there are any more issues. Also, how else could I help out here?

Merged! Great job here @spiyer99. If you're looking for an easy issue to tackle, we need to remove this code from the L1CrossDomainMessenger and fix any tests that might break when that code gets removed:

Please make this change against the experimental branch if you decide to tackle it! https://github.com/ethereum-optimism/optimism/tree/experimental

Merged! Great job here @spiyer99. If you're looking for an easy issue to tackle, we need to remove this code from the L1CrossDomainMessenger and fix any tests that might break when that code gets removed:

optimism/packages/contracts/contracts/L1/messaging/L1CrossDomainMessenger.sol

Lines 78 to 95 in 029cafc

	/**********************
	* Function Modifiers *
	**********************/
	/**
	* Modifier to enforce that, if configured, only the OVM_L2MessageRelayer contract may
	* successfully call a method.
	*/
	modifier onlyRelayer() {
	address relayer = resolve("OVM_L2MessageRelayer");
	if (relayer != address(0)) {
	require(
	msg.sender == relayer,
	"Only OVM_L2MessageRelayer can relay L2-to-L1 messages."
	);
	}
	_;
	}

Please make this change against the experimental branch if you decide to tackle it! https://github.com/ethereum-optimism/optimism/tree/experimental

@smartcontracts thanks for merging the PR!

Happy to work on the issue mentioned above. Should I create a formal issue before submitting a PR?