op-e2e: Refactor GeneratedTransaction to avoid tests needing to calculate identifiers and payloads.#14447
op-e2e: Refactor GeneratedTransaction to avoid tests needing to calculate identifiers and payloads.#14447
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14447 +/- ##
============================================
- Coverage 78.11% 41.87% -36.25%
============================================
Files 178 847 +669
Lines 10667 77868 +67201
============================================
+ Hits 8333 32605 +24272
- Misses 2143 42395 +40252
- Partials 191 2868 +2677
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Inphi
left a comment
There was a problem hiding this comment.
When I remove the skip, the cross safety checks at proofs_test.go L406 as now passing. Which suggests that the cyclic dependencies are now considered as valid. There hasn't been any recent changes to the supervisor so I think the test is broken somewhere.
|
Well crap - what did I change last minute that broke that again... it was failing like I expected. :) Good spot thank you. |
ajsutton
left a comment
There was a problem hiding this comment.
Fix the problem and it's now failing to advance the cross unsafe head as it does on develop.
…late identifiers and payloads. (ethereum-optimism#14447) * op-e2e: Refactor GeneratedTransaction to avoid tests needing to calculate identifiers and payloads. * op-e2e: Use a single method for inbox executing transactions. * op-e2e: Include transaction on correct chains. * Simplify further. * Skip test again.
Description
Refactors the interop DSL so that transaction creators return a
GeneratedTransactionand it can capture its receipt when it is included in a block. This allows it to calculate the identifier and payload even before the block it is included in is actually sealed.