feat: simplify DeployOPPU by removing unneeded inputs#14379
Merged
feat: simplify DeployOPPU by removing unneeded inputs#14379
Conversation
b8d09fb to
9b3a86b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14379 +/- ##
===========================================
+ Coverage 77.23% 85.41% +8.17%
===========================================
Files 178 121 -57
Lines 10667 5985 -4682
===========================================
- Hits 8239 5112 -3127
+ Misses 2247 861 -1386
+ Partials 181 12 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mds1
reviewed
Feb 14, 2025
packages/contracts-bedrock/scripts/deploy/DeployOPPrestateUpdater.s.sol
Outdated
Show resolved
Hide resolved
341dc2b to
f014037
Compare
maurelian
commented
Feb 21, 2025
mds1
reviewed
Feb 21, 2025
mds1
reviewed
Feb 21, 2025
mds1
reviewed
Feb 21, 2025
mds1
approved these changes
Feb 21, 2025
Contributor
mds1
left a comment
There was a problem hiding this comment.
I verified the hardcoded bytecode matches the 1.8.0 release here: #14379 (comment)
Two small comments that you can self-resolve as appropriate before merge, so approving
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
…ism#14379) * feat: simplify by removing unneeded inputs * Remove io contracts * feat: get addrs from registry * feat: get pdg blueprint from current opcm * feat: add plan for getting fdg code * feat: Add permissionlessDisputeGame bytecode and blueprint creation * feat: Add blueprints checks * fix: semgrep rule * lint * fix: use correct initcode * fix: correct encoding of initCode * semver * fix imports * feat: move IOPCM180 to /interfaces * feat: print fdg initCodeHash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Massively simplifies the DeployOPPU script, since it doesn't need to work with opd.