Skip to content

docs: Add frozen code checks docs to readme.#14057

Merged
maurelian merged 2 commits intodevelopfrom
maur/frozen-readme
Jan 29, 2025
Merged

docs: Add frozen code checks docs to readme.#14057
maurelian merged 2 commits intodevelopfrom
maur/frozen-readme

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Documents #14024

@maurelian maurelian requested a review from a team as a code owner January 29, 2025 21:09
@maurelian maurelian requested a review from agusduha January 29, 2025 21:09
@agusduha
Copy link
Copy Markdown
Contributor

Can we add some sort of estimated time for code freezing? I believe it would give more insight to handle pending PRs

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.78%. Comparing base (b5d2544) to head (0683799).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14057      +/-   ##
===========================================
- Coverage    47.02%   45.78%   -1.25%     
===========================================
  Files          975      918      -57     
  Lines        81768    77100    -4668     
===========================================
- Hits         38455    35302    -3153     
+ Misses       40421    39077    -1344     
+ Partials      2892     2721     -171     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 95.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

@maurelian
Copy link
Copy Markdown
Contributor Author

Can we add some sort of estimated time for code freezing? I believe it would give more insight to handle pending PRs

where would you like to see that @agusduha ?

Copy link
Copy Markdown
Contributor

@AmadiMichael AmadiMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I agree with @agusduha that an ETA should be added, maybe as a comment above the set of files in question

@agusduha
Copy link
Copy Markdown
Contributor

That sounds good, if it can be part of the check script result it could be even better

Sorry for commenting here i didn't notice the implementation PR @AmadiMichael @maurelian

@maurelian
Copy link
Copy Markdown
Contributor Author

maurelian commented Jan 29, 2025

@agusduha I added a date of Feb 20 to the output. That is a worst case.

0683799

@maurelian maurelian enabled auto-merge January 29, 2025 21:24
@maurelian maurelian added this pull request to the merge queue Jan 29, 2025
Merged via the queue into develop with commit eedd862 Jan 29, 2025
@maurelian maurelian deleted the maur/frozen-readme branch January 29, 2025 21:34
Rjected pushed a commit to paradigmxyz/optimism that referenced this pull request Feb 25, 2025
* docs: Add frozen code checks docs to readme.

* feat: Add lift date to script output
QuentinI pushed a commit to EspressoSystems/optimism-espresso-integration that referenced this pull request Mar 7, 2025
* docs: Add frozen code checks docs to readme.

* feat: Add lift date to script output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants