Merged
Conversation
🦋 Changeset detectedLatest commit: 8da0450 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f6f199b to
6ac7d0a
Compare
6ac7d0a to
8d4a5ad
Compare
Contributor
|
I've updated this PR with a rebase and a |
8d4a5ad to
3c31643
Compare
Contributor
|
Updated in a way to make it backwards compatible |
336c973 to
647cd98
Compare
tynes
reviewed
Sep 21, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1404 +/- ##
===========================================
- Coverage 76.47% 76.29% -0.18%
===========================================
Files 81 81
Lines 3018 3029 +11
Branches 463 463
===========================================
+ Hits 2308 2311 +3
- Misses 710 718 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Adds new config options to the watcher to allow it to upgrade in a non breaking way. New config options include setting a global `pollForPending` and `blocksToFetch`. It is also possible to specify the number of blocks to fetch on each `Layer`. The event ids are precomputed and held as globals instead of computed on the fly each time.
647cd98 to
8da0450
Compare
K-Ho
approved these changes
Sep 21, 2021
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Watcher utility currently has a single
blocksToFetchfor both layers, which isn't ideal because L2 has much faster block times. This PR definesl1BlocksToFetchandl2BlocksToFethNote - I'm not sure why it added all the change set stuff. Feel free to remove if needed.