Skip to content

chore: Refactor code to use SR2 bindings#13997

Merged
sebastianst merged 1 commit intodevelopfrom
feat/sr2-bindings
Jan 27, 2025
Merged

chore: Refactor code to use SR2 bindings#13997
sebastianst merged 1 commit intodevelopfrom
feat/sr2-bindings

Conversation

@mslipper
Copy link
Copy Markdown
Contributor

@mslipper mslipper commented Jan 27, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.72727% with 68 lines in your changes missing coverage. Please review.

Project coverage is 46.53%. Comparing base (51b2632) to head (bb29dee).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/superchain.go 0.00% 38 Missing ⚠️
op-dispute-mon/flags/flags.go 0.00% 7 Missing ⚠️
op-node/chaincfg/chains.go 57.14% 4 Missing and 2 partials ⚠️
op-challenger/flags/flags.go 0.00% 5 Missing ⚠️
op-deployer/pkg/deployer/standard/standard.go 0.00% 4 Missing ⚠️
op-service/superutil/chain_config.go 71.42% 3 Missing and 1 partial ⚠️
op-deployer/pkg/deployer/pipeline/init.go 0.00% 2 Missing ⚠️
op-chain-ops/cmd/op-simulate/main.go 0.00% 1 Missing ⚠️
op-program/chainconfig/chaincfg.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (51b2632) and HEAD (bb29dee). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (51b2632) HEAD (bb29dee)
contracts-bedrock-tests 2 1
2 1
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop   #13997       +/-   ##
============================================
- Coverage    75.78%   46.53%   -29.26%     
============================================
  Files          168      973      +805     
  Lines         9722    81317    +71595     
  Branches       759      759               
============================================
+ Hits          7368    37840    +30472     
- Misses        2080    40565    +38485     
- Partials       274     2912     +2638
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (ø)
cannon-go-tests-64 56.62% <ø> (ø)
contracts-bedrock-tests 87.67% <ø> (-2.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-deployer/pkg/deployer/inspect/flags.go 0.00% <ø> (ø)
op-deployer/pkg/deployer/state/intent.go 44.93% <100.00%> (ø)
op-program/host/config/config.go 43.11% <100.00%> (ø)
op-chain-ops/cmd/op-simulate/main.go 0.00% <0.00%> (ø)
op-program/chainconfig/chaincfg.go 35.41% <0.00%> (ø)
op-deployer/pkg/deployer/pipeline/init.go 47.52% <0.00%> (ø)
op-deployer/pkg/deployer/standard/standard.go 12.92% <0.00%> (ø)
op-service/superutil/chain_config.go 71.42% <71.42%> (ø)
op-challenger/flags/flags.go 10.73% <0.00%> (ø)
op-node/chaincfg/chains.go 50.98% <57.14%> (ø)
... and 2 more

... and 811 files with indirect coverage changes

sebastianst
sebastianst reviewed Jan 27, 2025
View reviewed changes
Comment thread go.mod Outdated
@mslipper mslipper marked this pull request as ready for review January 27, 2025 17:13
@mslipper mslipper requested review from a team, Inphi, ajsutton and smartcontracts January 27, 2025 17:13
@mslipper mslipper force-pushed the feat/sr2-bindings branch 6 times, most recently from 27d7add to bd8c959 Compare January 27, 2025 17:31
@sebastianst sebastianst linked an issue Jan 27, 2025 that may be closed by this pull request
superchain: adapt to SR 2.0 API #13957
Closed
@sebastianst sebastianst added this pull request to the merge queue Jan 27, 2025
Merged via the queue into develop with commit 1703583 Jan 27, 2025
@sebastianst sebastianst deleted the feat/sr2-bindings branch January 27, 2025 18:30
Rjected pushed a commit to paradigmxyz/optimism that referenced this pull request Feb 25, 2025
@mslipper @Rjected
chore: Refactor code to use SR2 bindings (ethereum-optimism#13997)
2ff5efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastianst sebastianst sebastianst approved these changes

@Inphi Inphi Awaiting requested review from Inphi

@ajsutton ajsutton Awaiting requested review from ajsutton

@smartcontracts smartcontracts Awaiting requested review from smartcontracts

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

superchain: adapt to SR 2.0 API

2 participants

@mslipper @sebastianst