Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
06969a2 to
64233a9
Compare
64233a9 to
e92163d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13979 +/- ##
============================================
+ Coverage 46.59% 81.53% +34.94%
============================================
Files 973 111 -862
Lines 81468 5054 -76414
Branches 757 759 +2
============================================
- Hits 37961 4121 -33840
+ Misses 40590 870 -39720
+ Partials 2917 63 -2854
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e92163d to
3b128f6
Compare
4720bc7 to
2caadac
Compare
4720bc7 to
2caadac
Compare
3b128f6 to
0a1afaf
Compare
2caadac to
4720bc7
Compare
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
mds1
reviewed
Jan 27, 2025
feat: Move superchainProxy admin from opcm upgrade() to constructor()
samlaf
pushed a commit
to Layr-Labs/optimism
that referenced
this pull request
Jan 27, 2025
* mtcannon upgrade notes * mtcannon upgrade strawman impl * rename mips to mips64 * feat: rename _currentGame to _disputeGame * feat: Move has input into the OpChain struct, and take one per game * bump semvers * feat: rename OpChains to OpChainConfigs and mips to mips64 * feat: Add PrestateNotSet error and tests * test fixes * fix snapshots and interfaces * fix empty prestate tests * semver * update arg name to _opChainConfig * Deploy Mips64 in test * Address feedback in OPCM.t.sol * refactor: only take one absolute prestate per chain * feat: Move superchainProxy admin from opcm upgrade() to constructor() * Make use of named variable in deploy.s.sol * feat: Add state var checks to ChainAssertsion.checkOPCM * wip: adding SuperchainProxyAdmin to op-deployer * fix: Correct check of scc and pv impls in chainAssertions.opcm * lint and fix unused import --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
* mtcannon upgrade notes * mtcannon upgrade strawman impl * rename mips to mips64 * feat: rename _currentGame to _disputeGame * feat: Move has input into the OpChain struct, and take one per game * bump semvers * feat: rename OpChains to OpChainConfigs and mips to mips64 * feat: Add PrestateNotSet error and tests * test fixes * fix snapshots and interfaces * fix empty prestate tests * semver * update arg name to _opChainConfig * Deploy Mips64 in test * Address feedback in OPCM.t.sol * refactor: only take one absolute prestate per chain * feat: Move superchainProxy admin from opcm upgrade() to constructor() * Make use of named variable in deploy.s.sol * feat: Add state var checks to ChainAssertsion.checkOPCM * wip: adding SuperchainProxyAdmin to op-deployer * fix: Correct check of scc and pv impls in chainAssertions.opcm * lint and fix unused import --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
QuentinI
pushed a commit
to EspressoSystems/optimism-espresso-integration
that referenced
this pull request
Mar 7, 2025
* mtcannon upgrade notes * mtcannon upgrade strawman impl * rename mips to mips64 * feat: rename _currentGame to _disputeGame * feat: Move has input into the OpChain struct, and take one per game * bump semvers * feat: rename OpChains to OpChainConfigs and mips to mips64 * feat: Add PrestateNotSet error and tests * test fixes * fix snapshots and interfaces * fix empty prestate tests * semver * update arg name to _opChainConfig * Deploy Mips64 in test * Address feedback in OPCM.t.sol * refactor: only take one absolute prestate per chain * feat: Move superchainProxy admin from opcm upgrade() to constructor() * Make use of named variable in deploy.s.sol * feat: Add state var checks to ChainAssertsion.checkOPCM * wip: adding SuperchainProxyAdmin to op-deployer * fix: Correct check of scc and pv impls in chainAssertions.opcm * lint and fix unused import --------- Co-authored-by: Matt Solomon <matt@mattsolomon.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mipsImpltomips64Implin the Implementations struct