op-supervisor: Add cross-safe L1 block to SuperRootResponse#13951
Merged
op-supervisor: Add cross-safe L1 block to SuperRootResponse#13951
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13951 +/- ##
===========================================
- Coverage 46.77% 45.54% -1.23%
===========================================
Files 972 915 -57
Lines 81029 76383 -4646
Branches 756 756
===========================================
- Hits 37898 34791 -3107
+ Misses 40212 38810 -1402
+ Partials 2919 2782 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aac3254 to
3b9297d
Compare
3b9297d to
56879fb
Compare
ajsutton
approved these changes
Jan 28, 2025
Contributor
ajsutton
left a comment
There was a problem hiding this comment.
Makes sense to me but would ideally like someone more familiar with op-supervisor to take a look. Will see if I can chase someone up in discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the L1 block that a super root can be considered cross-safe. This is the earliest block that indicates cross-safety in the super root.
It'll be used later by the challenger to determine when its view of the chain is synchronized enough to participate in dispute games.
Fixes #13890