Skip to content

ci: print the diff in contracts-checks#13937

Merged
mslipper merged 1 commit intodevelopfrom
ci/print-diff
Jan 24, 2025
Merged

ci: print the diff in contracts-checks#13937
mslipper merged 1 commit intodevelopfrom
ci/print-diff

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Description

When a git diff check fails in CI, we should just print the diff to make it easier to debug.

@maurelian maurelian requested review from a team and sigma January 23, 2025 14:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.67%. Comparing base (969382a) to head (762a5e4).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13937      +/-   ##
===========================================
- Coverage    46.96%   46.67%   -0.29%     
===========================================
  Files          973      973              
  Lines        80990    80990              
  Branches       755      755              
===========================================
- Hits         38035    37803     -232     
- Misses       39991    40273     +282     
+ Partials      2964     2914      -50     
Flag Coverage Δ
cannon-go-tests-32 61.99% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.62% <ø> (-1.66%) ⬇️
contracts-bedrock-tests 88.19% <ø> (-2.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 39 files with indirect coverage changes

@maurelian maurelian added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@maurelian maurelian added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@mslipper
Copy link
Copy Markdown
Contributor

fixed the broken runner, merging again

@mslipper mslipper added this pull request to the merge queue Jan 23, 2025
@mslipper mslipper removed this pull request from the merge queue due to a manual request Jan 23, 2025
@mslipper
Copy link
Copy Markdown
Contributor

never mind, this is still broken

@mslipper mslipper added this pull request to the merge queue Jan 23, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 23, 2025
@mslipper mslipper added this pull request to the merge queue Jan 24, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 24, 2025
@mslipper mslipper added this pull request to the merge queue Jan 24, 2025
Merged via the queue into develop with commit 281d35b Jan 24, 2025
@mslipper mslipper deleted the ci/print-diff branch January 24, 2025 15:01
Rjected pushed a commit to paradigmxyz/optimism that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants