op-program: Replace invalid msg blocks with deposits-only block#13826
Merged
op-program: Replace invalid msg blocks with deposits-only block#13826
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13826 +/- ##
============================================
- Coverage 46.86% 11.86% -35.01%
============================================
Files 973 3 -970
Lines 81334 413 -80921
Branches 759 0 -759
============================================
- Hits 38118 49 -38069
+ Misses 40245 346 -39899
+ Partials 2971 18 -2953
Flags with carried forward coverage won't be shown. Click here to find out more. |
5abc4b8 to
497ce47
Compare
ajsutton
reviewed
Jan 17, 2025
Inphi
commented
Jan 28, 2025
ajsutton
reviewed
Jan 28, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
…reum-optimism#13826) * op-program: Replace invalid msg blocks with deposits-only block * wip * setup some testing scenes * rename mut fns * add missing file * misunderstood spec; append deposited tx * use eth.ChainID * construct the optimistic output preimage in the client * add issue ref in todo * ref todo
QuentinI
pushed a commit
to EspressoSystems/optimism-espresso-integration
that referenced
this pull request
Mar 7, 2025
…reum-optimism#13826) * op-program: Replace invalid msg blocks with deposits-only block * wip * setup some testing scenes * rename mut fns * add missing file * misunderstood spec; append deposited tx * use eth.ChainID * construct the optimistic output preimage in the client * add issue ref in todo * ref todo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an optimistic block in the transition state is found to contain invalid execution messages, it is replaced with a deposit-only block.
This follows the same consensus rules of cross-safety block promotion.
This patch also adds a sanity check to the prefetcher to ensure that the program execution generates the requested block. An error is logged when this does not occur. It would be difficult to detect otherwise as the client would wait indefinitely for a preimage that doesn't exist.
fixes #13882
Testing
Unit tests in the op-program with stubs. Action tests will be added in another PR.