interop: Fix Managed Mode Reset ; Add Reset Action Test#13821
Merged
protolambda merged 3 commits intodevelopfrom Jan 24, 2025
Merged
interop: Fix Managed Mode Reset ; Add Reset Action Test#13821protolambda merged 3 commits intodevelopfrom
protolambda merged 3 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13821 +/- ##
===========================================
- Coverage 47.04% 45.52% -1.52%
===========================================
Files 973 916 -57
Lines 81123 76360 -4763
Branches 776 776
===========================================
- Hits 38161 34765 -3396
+ Misses 40003 38852 -1151
+ Partials 2959 2743 -216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
d94f270 to
3baa3f4
Compare
3ee8fc2 to
e10ca71
Compare
3baa3f4 to
62d4ca2
Compare
fb1aadc to
e0d8a4c
Compare
e0d8a4c to
c0a81b3
Compare
protolambda
reviewed
Jan 24, 2025
protolambda
approved these changes
Jan 24, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
…imism#13821) * interop: Add Rewind Action Test * Fix Reset on Managed Node * PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Managed Mode Reset Handling, and introduces an Action Test demonstrating functionality.
Significant Changes:
unsafe3 times, when it should have been validatingunsafe,safe,finalized, leading to the unsafe head being used for all new heads when resetting the Engine Controller.ErrOutOfOrderin the Supervisor was previously assumed to be an ignorable error, but it actually needs to trigger a reset, because it indicates that we have a gap in the Derivation DBs (event DB is always indexed in order since the indexer controls the fetch and insert of all events). That gap in the Derivation DB must be solved by rewinding the node to recreate the derivation events.resetSignalfunction was improved to useerrors.Is. Likely this whole function should be collapsed into someInvalidatorcomponent we are looking to build shortly.