Skip to content

feat: Upgrade OPContractsManager to deploy new ASR and dispute games #13803

Merged
maurelian merged 19 commits intodevelopfrom
opcm-up/upgrade-asr
Jan 23, 2025
Merged

feat: Upgrade OPContractsManager to deploy new ASR and dispute games #13803
maurelian merged 19 commits intodevelopfrom
opcm-up/upgrade-asr

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Jan 16, 2025 •
edited
Loading

This PR updates the OPContractsManager's upgrade() function to:

  • Deploy a new AnchorStateRegistry proxy. The startingAnchorRoot is taken from the current respectedGameType
  • Deploy a new implementation of the permissioned dispute game.
    • if the permissionless dispute game is enabled, a new implementation of it is also deployed.
  • Update the WETH implementations (keeping the existing proxies)
  • Set the new game implementations in the DisputeGameFactory
  • Add optimizer settings for OPContractsManager, necessary to keep the code size below the maximum.

This was referenced Jan 16, 2025
Merged
Merged
@maurelian Graphite App
Copy link
Copy Markdown
Contributor Author

maurelian commented Jan 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (969382a) to head (d14c0c6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...es/contracts-bedrock/src/L1/OPContractsManager.sol 0.00% 38 Missing ⚠️
...racts-bedrock/src/L1/OPContractsManagerInterop.sol 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #13803      +/-   ##
===========================================
- Coverage    46.96%   45.59%   -1.37%     
===========================================
  Files          973      916      -57     
  Lines        80990    76339    -4651     
  Branches       755      756       +1     
===========================================
- Hits         38035    34807    -3228     
+ Misses       39991    38746    -1245     
+ Partials      2964     2786     -178
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 90.55% <0.00%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...racts-bedrock/src/L1/OPContractsManagerInterop.sol 71.42% <0.00%> (ø)
...es/contracts-bedrock/src/L1/OPContractsManager.sol 71.49% <0.00%> (-6.40%) ⬇️

... and 67 files with indirect coverage changes

@maurelian maurelian mentioned this pull request Jan 16, 2025
Merged
maurelian
maurelian commented Jan 16, 2025
View reviewed changes
maurelian
maurelian commented Jan 16, 2025
View reviewed changes
maurelian
maurelian commented Jan 16, 2025
View reviewed changes
@maurelian maurelian force-pushed the opcm-up/update-impls-only branch from 3bd191a to 5fdbe35 Compare January 16, 2025 20:42
@maurelian maurelian force-pushed the opcm-up/upgrade-asr branch from ad84635 to b633209 Compare January 16, 2025 20:42
@maurelian maurelian marked this pull request as ready for review January 16, 2025 20:45
@maurelian maurelian requested a review from a team as a code owner January 16, 2025 20:45
@maurelian maurelian requested review from clabby and removed request for a team January 16, 2025 20:45
@maurelian maurelian force-pushed the opcm-up/update-impls-only branch from 5fdbe35 to 14e96b2 Compare January 16, 2025 21:00
@maurelian maurelian requested review from a team as code owners January 16, 2025 21:00
@maurelian maurelian requested review from ajsutton, axelKingsley, blmalone and mslipper and removed request for a team January 16, 2025 21:00
@maurelian maurelian force-pushed the opcm-up/upgrade-asr branch 5 times, most recently from b470576 to fcb4175 Compare January 23, 2025 06:23
@maurelian maurelian enabled auto-merge January 23, 2025 13:23
@maurelian maurelian force-pushed the opcm-up/upgrade-asr branch from 5607ae4 to d14c0c6 Compare January 23, 2025 14:26
@maurelian maurelian added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit 47c00f9 Jan 23, 2025
@maurelian maurelian mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts left review comments

@mds1 mds1 mds1 approved these changes

@clabby clabby Awaiting requested review from clabby clabby is a code owner automatically assigned from ethereum-optimism/contract-reviewers

@blmalone blmalone Awaiting requested review from blmalone blmalone was automatically assigned from ethereum-optimism/go-reviewers

@mslipper mslipper Awaiting requested review from mslipper mslipper was automatically assigned from ethereum-optimism/op-conductor

@axelKingsley axelKingsley Awaiting requested review from axelKingsley axelKingsley was automatically assigned from ethereum-optimism/interop

@ajsutton ajsutton Awaiting requested review from ajsutton ajsutton was automatically assigned from ethereum-optimism/consensus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelian @smartcontracts @mds1