Skip to content

feat: introduce op-dripper#13788

Merged
smartcontracts merged 1 commit intodevelopfrom
sc/op-dripper
Jan 23, 2025
Merged

feat: introduce op-dripper#13788
smartcontracts merged 1 commit intodevelopfrom
sc/op-dripper

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description

Introduces op-dripper as a replacement for Gelato automation of Drippie. Gelato no longer supports querying balances onchain which makes self-sustaining automation difficult. This PR removes all references to Gelato and introduces the new service.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.68%. Comparing base (3cc36be) to head (83983ce).
Report is 80 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13788      +/-   ##
===========================================
- Coverage    47.03%   45.68%   -1.36%     
===========================================
  Files          957      899      -58     
  Lines        80029    75249    -4780     
  Branches       758      758              
===========================================
- Hits         37642    34377    -3265     
+ Misses       39529    38188    -1341     
+ Partials      2858     2684     -174     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 88.97% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 72 files with indirect coverage changes

@smartcontracts smartcontracts force-pushed the sc/op-dripper branch 2 times, most recently from b75bce8 to 1588bbb Compare January 15, 2025 17:52
@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jan 15, 2025

Does this need to live in the monorepo?

@smartcontracts
Copy link
Copy Markdown
Contributor Author

Does this need to live in the monorepo?

@mslipper suggested that it live in the monorepo. Balance management is a relatively core part of the system IMO, so I think it seems reasonable to have it live here.

@ControlCplusControlV
Copy link
Copy Markdown
Contributor

Where else would it go besides the monorepo? Monitorism isn't quite the right place imo because its critical to production in keeping things funded

@smartcontracts
Copy link
Copy Markdown
Contributor Author

As a side note, it would be nice if we moved the Drippie configuration and management tooling into this package to cut out stuff from the contracts package.

@smartcontracts smartcontracts marked this pull request as ready for review January 21, 2025 17:56
@smartcontracts smartcontracts requested review from a team as code owners January 21, 2025 17:56
@smartcontracts smartcontracts requested a review from tynes January 21, 2025 17:56
Copy link
Copy Markdown
Contributor

@mslipper mslipper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm left a few nits

@smartcontracts smartcontracts added this pull request to the merge queue Jan 23, 2025
Merged via the queue into develop with commit d4ebcd2 Jan 23, 2025
@smartcontracts smartcontracts deleted the sc/op-dripper branch January 23, 2025 21:52
maurelian pushed a commit that referenced this pull request Jan 24, 2025
samlaf pushed a commit to Layr-Labs/optimism that referenced this pull request Jan 27, 2025
QuentinI pushed a commit to EspressoSystems/optimism-espresso-integration that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants