feat(ci): check that Kontrol summary files are unchanged#12592
Merged
smartcontracts merged 1 commit intodevelopfrom Oct 26, 2024
Merged
feat(ci): check that Kontrol summary files are unchanged#12592smartcontracts merged 1 commit intodevelopfrom
smartcontracts merged 1 commit intodevelopfrom
Conversation
Updates CI to check that the Kontrol summary dummy files are not modified by any PR unless the change is deliberate. Committed files are dummy files and aren't meant to change. Alternative here would be to generate the dummy files with a script that gets triggered before forge builds stuff. Main concern with using an autogen script is that the script would need to be added in front of build commands all over the place. Committing the files and checking that they aren't changed is slightly more janky but people rarely re-generate these files anyway so the projected impact is minimal. If this becomes a devx hassle we can consider autogen.
mds1
reviewed
Oct 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12592 +/- ##
===========================================
- Coverage 65.04% 64.86% -0.18%
===========================================
Files 54 54
Lines 4460 4460
===========================================
- Hits 2901 2893 -8
- Misses 1382 1391 +9
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…timism#12592) Updates CI to check that the Kontrol summary dummy files are not modified by any PR unless the change is deliberate. Committed files are dummy files and aren't meant to change. Alternative here would be to generate the dummy files with a script that gets triggered before forge builds stuff. Main concern with using an autogen script is that the script would need to be added in front of build commands all over the place. Committing the files and checking that they aren't changed is slightly more janky but people rarely re-generate these files anyway so the projected impact is minimal. If this becomes a devx hassle we can consider autogen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates CI to check that the Kontrol summary dummy files are not modified by any PR unless the change is deliberate. Committed files are dummy files and aren't meant to change.
Alternative here would be to generate the dummy files with a script that gets triggered before forge builds stuff. Main concern with using an autogen script is that the script would need to be added in front of build commands all over the place. Committing the files and checking that they aren't changed is slightly more janky but people rarely re-generate these files anyway so the projected impact is minimal.
If this becomes a devx hassle we can consider autogen.