op-program: Only allow requests for rollup config and l2 chain config for custom chains#12420
Merged
op-program: Only allow requests for rollup config and l2 chain config for custom chains#12420
Conversation
… for custom chains
Contributor
|
Semgrep found 1 TODO in error handling code Ignore this finding from err-todo. |
Inphi
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modifies op-program host to refuse to return the rollup config and L2 chain config unless the chain ID is the custom chain ID marker value. Those keys aren't available on chain since the contracts can't populate them. The client won't request them unless the right chain ID is used, but worth being safe and making op-program host as compatible with on-chain as possible too.
Tests
Updated unit tests.