Skip to content

op-node/rollup/derive: Holocene Batch Stage#12417

Merged
sebastianst merged 1 commit intodevelopfrom
seb/holocene-batch-stage
Oct 22, 2024
Merged

op-node/rollup/derive: Holocene Batch Stage#12417
sebastianst merged 1 commit intodevelopfrom
seb/holocene-batch-stage

Conversation

@sebastianst
Copy link
Copy Markdown
Member

@sebastianst sebastianst commented Oct 10, 2024 •
edited
Loading

Description

Implements the Holocene BatchStage. It is a new derivation stage that replaces the BatchQueue past-Holocene activation. It shares common code with the BatchQueue via a baseBatchStage.

Needs #12157 to get wired into the derivation pipeline.

❗ Stacked on top of #12497 which needs to be merged first!

Tests

  • Added new test cases for checkBatch... behavior with Holocene.
  • Parameterized existing applicable BatchQueue tests to also run on the BatchStage. Note that the batch stage is actually simpler than the batch queue because it doesn't queue up batches, so two tests that were specific to queueing behavior don't run on the stage.
  • Action tests will be added in the future (Holocene-D: Action Tests #12449) to fully test the BatchStage, especially partial span batch validity.

Additional context

Non-critical follow-ups and observations collected at #12444

Metadata

@sebastianst sebastianst added A-op-node Area: op-node T-protocol Team: changes to node components (op-node, op-reth, etc.) implemented by go/rust/etc. devs labels Oct 10, 2024
@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app bot commented Oct 10, 2024

Semgrep found 4 sol-style-return-arg-fmt findings:

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

Semgrep found 2 sol-style-malformed-revert findings:

  • packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • packages/contracts-bedrock/scripts/deploy/Deploy.s.sol

Malformed revert statement style.

Ignore this finding from sol-style-malformed-revert.

Semgrep found 22 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

Semgrep found 13 sol-style-malformed-require findings:

  • packages/contracts-bedrock/src/cannon/PreimageOracle.sol
  • packages/contracts-bedrock/scripts/periphery/deploy/DeployPeriphery.s.sol
  • packages/contracts-bedrock/scripts/libraries/DeployUtils.sol
  • packages/contracts-bedrock/scripts/deploy/DeployOwnership.s.sol
  • packages/contracts-bedrock/scripts/deploy/DeployConfig.s.sol
  • packages/contracts-bedrock/scripts/deploy/Deploy.s.sol
  • packages/contracts-bedrock/scripts/deploy/ChainAssertions.sol
  • packages/contracts-bedrock/scripts/autogen/SemverLock.s.sol
  • packages/contracts-bedrock/scripts/DeploySuperchain.s.sol

"challenge period too large" Malformed require statement style.

Ignore this finding from sol-style-malformed-require.

@semgrep-app
Copy link
Copy Markdown
Contributor

semgrep-app bot commented Oct 13, 2024

Semgrep found 3 sol-style-require-reason findings:

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Semgrep found 1 err-todo finding:

  • op-program/client/l2/engineapi/l2_engine_api.go

TODO in error handling code

Ignore this finding from err-todo.

@sebastianst sebastianst mentioned this pull request Oct 14, 2024
Closed
7 tasks
@sebastianst sebastianst marked this pull request as ready for review October 14, 2024 19:17
@sebastianst sebastianst requested review from a team as code owners October 14, 2024 19:17
@sebastianst sebastianst requested review from protolambda and removed request for a team October 14, 2024 19:17
tynes
tynes reviewed Oct 14, 2024
View reviewed changes
tynes
tynes reviewed Oct 14, 2024
View reviewed changes
@sebastianst sebastianst force-pushed the seb/holocene-channel-stage branch from 625f355 to c97ded3 Compare October 15, 2024 14:00
@sebastianst sebastianst requested a review from a team as a code owner October 15, 2024 14:00
@sebastianst sebastianst self-assigned this Oct 15, 2024
@sebastianst sebastianst added this to the Holocene: Derivation milestone Oct 15, 2024
@sebastianst sebastianst force-pushed the seb/holocene-batch-stage branch from bb06375 to 7810f0a Compare October 15, 2024 14:47
Base automatically changed from seb/holocene-channel-stage to develop October 15, 2024 14:50
@sebastianst sebastianst force-pushed the seb/holocene-batch-stage branch from 7810f0a to 9853bf0 Compare October 15, 2024 16:33
geoknee
geoknee reviewed Oct 16, 2024
View reviewed changes
@sebastianst sebastianst force-pushed the seb/holocene-batch-stage branch 2 times, most recently from a841424 to 12eae24 Compare October 17, 2024 20:56
@sebastianst sebastianst changed the base branch from develop to holocene-1559 October 17, 2024 20:56
ajsutton
ajsutton approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@roberto-bayardo roberto-bayardo force-pushed the holocene-1559 branch 6 times, most recently from 6cd237f to e6c5527 Compare October 18, 2024 17:06
@sebastianst sebastianst mentioned this pull request Oct 21, 2024
Merged
@sebastianst sebastianst added the M-do-not-merge Meta: Do not merge label Oct 21, 2024
Base automatically changed from holocene-1559 to develop October 21, 2024 20:28
@sebastianst sebastianst mentioned this pull request Oct 22, 2024
Closed
@sebastianst sebastianst force-pushed the seb/holocene-batch-stage branch from 12eae24 to defbbf4 Compare October 22, 2024 14:20
@sebastianst sebastianst enabled auto-merge October 22, 2024 14:21
@sebastianst sebastianst force-pushed the seb/holocene-batch-stage branch from defbbf4 to 8899e8b Compare October 22, 2024 15:26
@sebastianst sebastianst added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@sebastianst sebastianst added this pull request to the merge queue Oct 22, 2024
Merged via the queue into develop with commit 5808985 Oct 22, 2024
@sebastianst sebastianst deleted the seb/holocene-batch-stage branch October 22, 2024 15:54
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@sebastianst @samlaf
op-node/rollup/derive: Implement Holocene Batch Stage (ethereum-optim…
f573574 
…ism#12417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoknee geoknee geoknee left review comments

@tynes tynes tynes left review comments

@ajsutton ajsutton ajsutton approved these changes

@protolambda protolambda Awaiting requested review from protolambda protolambda is a code owner automatically assigned from ethereum-optimism/consensus

Assignees

@sebastianst sebastianst

Labels

A-op-node Area: op-node M-do-not-merge Meta: Do not merge T-protocol Team: changes to node components (op-node, op-reth, etc.) implemented by go/rust/etc. devs

Projects

None yet

Milestone

Holocene: Derivation

4 participants

@sebastianst @ajsutton @geoknee @tynes