Skip to content

cannon: Fix 64-bit test compilation#12416

Merged
mbaxter merged 2 commits intoethereum-optimism:developfrom
mbaxter:issue-12198/followup/fix-word-types
Oct 10, 2024
Merged

cannon: Fix 64-bit test compilation#12416
mbaxter merged 2 commits intoethereum-optimism:developfrom
mbaxter:issue-12198/followup/fix-word-types

Conversation

@mbaxter
Copy link
Copy Markdown
Contributor

@mbaxter mbaxter commented Oct 10, 2024

Description
Follow-up to #12200 - fix 64-bit test compilation by switching types from uint32 to Word.

Also:

  • Update testutil to generate test cases based on architecture.
  • Cleanup white space
  • Make small tweaks to TestEVMFault

Metadata
Follow-up to #12198

@mbaxter mbaxter requested a review from Inphi October 10, 2024 19:24
@mbaxter mbaxter marked this pull request as ready for review October 10, 2024 19:24
@mbaxter mbaxter requested review from a team as code owners October 10, 2024 19:24
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.04%. Comparing base (d1882af) to head (1868082).

Files with missing lines Patch % Lines
cannon/mipsevm/tests/helpers.go 61.53% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #12416      +/-   ##
===========================================
- Coverage    64.14%   64.04%   -0.10%     
===========================================
  Files           52       52              
  Lines         4348     4353       +5     
===========================================
- Hits          2789     2788       -1     
- Misses        1385     1390       +5     
- Partials       174      175       +1
Flag Coverage Δ
cannon-go-tests 64.04% <64.28%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/testutil/mips.go 87.91% <100.00%> (-0.17%) ⬇️
cannon/mipsevm/tests/helpers.go 88.60% <61.53%> (-7.23%) ⬇️

Inphi
Inphi approved these changes Oct 10, 2024
View reviewed changes
@mbaxter mbaxter enabled auto-merge October 10, 2024 19:53
@mbaxter mbaxter added this pull request to the merge queue Oct 10, 2024
Merged via the queue into ethereum-optimism:develop with commit 9e1b6a9 Oct 10, 2024
@mbaxter mbaxter deleted the issue-12198/followup/fix-word-types branch October 10, 2024 20:15
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@mbaxter @samlaf
cannon: Fix 64-bit test compilation (ethereum-optimism#12416)
ae874ba 
* cannon: Fix test compilation for 64-bit

* cannon: Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Inphi Inphi Inphi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbaxter @Inphi