Skip to content

feat: add op-deployer inspect command#12375

Merged
mds1 merged 3 commits intodevelopfrom
op-deployer/inspect-l1
Oct 9, 2024
Merged

feat: add op-deployer inspect command#12375
mds1 merged 3 commits intodevelopfrom
op-deployer/inspect-l1

Conversation

@mds1
Copy link
Copy Markdown
Contributor

@mds1 mds1 commented Oct 8, 2024

Part of https://github.com/ethereum-optimism/platforms-team/issues/284

Adds l1 subcommand to op-deployer inspect so you can now run the below command.

$ op-deployer inspect l1 <l2-chain-id>
{
  "superchainDeployment": {
    "proxyAdminAddress": "0xdee57160aafcf04c34c887b5962d0a69676d3c8b",
    "superchainConfigProxyAddress": "0xc2be75506d5724086deb7245bd260cc9753911be",
    "superchainConfigImplAddress": "0x0000000000000000000000000000000000000000",
    "protocolVersionsProxyAddress": "0x79add5713b383daa0a138d3c4780c7a1804a8090",
    "protocolVersionsImplAddress": "0x0000000000000000000000000000000000000000"
  },
  "opChainDeployment": {
    "proxyAdminAddress": "0x59788b9bde63ff99582e565d749234d2accd74db",
    "addressManagerAddress": "0x22308bdbbca059e11d2f793cf42d4d56acacfb25",
    "l1ERC721BridgeProxyAddress": "0x7c1784531c228791c7bbb0274cab13eae3ecd8c6",
    "systemConfigProxyAddress": "0x6942c82bf49388083d47ec485925ba6a6b059204",
    "optimismMintableERC20FactoryProxyAddress": "0x69f5003cb43a0781ebb0c6b26d23b2346ddcbffc",
    "l1StandardBridgeProxyAddress": "0x5915c05a119c460051d8b06516e16ea256670500",
    "l1CrossDomainMessengerProxyAddress": "0xfd524201c927b1a4d3851f1f6544ac80fc5f6ef4",
    "optimismPortalProxyAddress": "0xf56ee26e2abf87dedd99913ad8ed6c0e58a30b49",
    "disputeGameFactoryProxyAddress": "0xb8aaf32a25a31d1b9f777b42990dd3bf997e1d31",
    "anchorStateRegistryProxyAddress": "0xcbdbd22f5b7697f77d85d199a0ee960d2fae8cf1",
    "anchorStateRegistryImplAddress": "0xec3b8f56ffda794b71076fda1f35971abea19d1f",
    "permissionedDisputeGameAddress": "0xe2e9aa6b7410afade1a94de341ebe9c93a8f1f33",
    "delayedWETHPermissionedGameProxyAddress": "0xabe89f9170148ec291e5a84d7586096b03451952"
  },
  "implementationsDeployment": {
    "opcmProxyAddress": "0x0f29118caed0f72873701bcc079398c594b6f8e4",
    "delayedWETHImplAddress": "0x0000000000000000000000000000000000000000",
    "optimismPortalImplAddress": "0x0000000000000000000000000000000000000000",
    "preimageOracleSingletonAddress": "0x0000000000000000000000000000000000000000",
    "mipsSingletonAddress": "0x0000000000000000000000000000000000000000",
    "systemConfigImplAddress": "0x0000000000000000000000000000000000000000",
    "l1CrossDomainMessengerImplAddress": "0x0000000000000000000000000000000000000000",
    "l1ERC721BridgeImplAddress": "0x0000000000000000000000000000000000000000",
    "l1StandardBridgeImplAddress": "0x0000000000000000000000000000000000000000",
    "optimismMintableERC20FactoryImplAddress": "0x0000000000000000000000000000000000000000",
    "disputeGameFactoryImplAddress": "0x0000000000000000000000000000000000000000"
  }
}

You'll notice a lot of addresses are the zero address. They are also the zero address in state.json, and fixing this is tracked under the "In state.json, some implementations and other addresses are the zero address" bullet of the linked issue

@mds1 mds1 requested review from bitwiseguy and blmalone October 8, 2024 22:17
@mds1 mds1 requested review from a team as code owners October 8, 2024 22:17
mds1
mds1 commented Oct 8, 2024
View reviewed changes
bitwiseguy
bitwiseguy reviewed Oct 9, 2024
View reviewed changes
bitwiseguy
bitwiseguy approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bitwiseguy bitwiseguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Not a blocker for this pr, but will note that we are also maintaining an AddressList of all contracts within the superchain-registry/superchain module here. We should try to think of way to ensure those lists stay in sync, or a way to combine them and import the same struct where needed

@mds1
Copy link
Copy Markdown
Contributor Author

mds1 commented Oct 9, 2024

Overall looks good to me. Not a blocker for this pr, but will note that we are also maintaining an AddressList of all contracts within the superchain-registry/superchain module here. We should try to think of way to ensure those lists stay in sync, or a way to combine them and import the same struct where needed

Created an issue to track this here: https://github.com/ethereum-optimism/platforms-team/issues/343

@mds1 mds1 enabled auto-merge October 9, 2024 15:13
@mds1 mds1 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into develop with commit 5f625e0 Oct 9, 2024
@mds1 mds1 deleted the op-deployer/inspect-l1 branch October 9, 2024 15:28
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
@mds1 @samlaf
feat: add op-deployer inspect command (ethereum-optimism#12375)
d108e32 
* feat: add op-deployer inspect command

* lint

* chore: clarify arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitwiseguy bitwiseguy bitwiseguy approved these changes

@blmalone blmalone Awaiting requested review from blmalone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mds1 @bitwiseguy