OPCM: AddressManager and ProxyAdmin assertions.#12370
Merged
Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blmalone
commented
Oct 8, 2024
mds1
reviewed
Oct 8, 2024
Contributor
|
Semgrep found 2 Named return arguments to functions must be appended with an underscore ( |
blmalone
commented
Oct 8, 2024
mds1
approved these changes
Oct 8, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
) * OPCM: AddressManager and ProxyAdmin assertions. * fix: Added logic for proxy types to check implementations. * fix: touch ups for RDP impl checking. * fix: fully fledged proxies added to tests because of new assertions. * fix: removing console2 lib. * fix: semgrep complaining. * fix: comment cleanup and logical split to avoid stack too deep error. * fix: adding comment back in. * fix: added natspec comments for new DeployUtils functions. * fix: removed unused imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding additional assertions for: