Merged
Conversation
mds1
reviewed
Oct 9, 2024
mds1
reviewed
Oct 9, 2024
mds1
approved these changes
Oct 9, 2024
Contributor
mds1
left a comment
There was a problem hiding this comment.
This is really great, just two small comments
Contributor
|
Semgrep found 4
Named return arguments to functions must be appended with an underscore ( Semgrep found 2
Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 22
Inputs to functions must be prepended with an underscore ( |
894d12e to
cfedf9b
Compare
Adds INTERFACES.md to explain how contract interfaces are used within the contracts-bedrock package.
cfedf9b to
9ef7b15
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Adds INTERFACES.md to explain how contract interfaces are used within the contracts-bedrock package.
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
Adds INTERFACES.md to explain how contract interfaces are used within the contracts-bedrock package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds INTERFACES.md to explain how contract interfaces are used within the contracts-bedrock package.