feat: op-program supports custom chain config#12310
feat: op-program supports custom chain config#12310ajsutton merged 6 commits intoethereum-optimism:developfrom
Conversation
ajsutton
left a comment
There was a problem hiding this comment.
Sorry for the delay in reviewing this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12310 +/- ##
===========================================
- Coverage 64.23% 64.04% -0.19%
===========================================
Files 52 52
Lines 4353 4353
===========================================
- Hits 2796 2788 -8
- Misses 1381 1390 +9
+ Partials 176 175 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ajsutton
left a comment
There was a problem hiding this comment.
Looking good. Maybe the best way forward is to do the couple of nits around providing better error messages and leave this PR running op-program in process and merge it. Then do a follow up PR to make --network support a chain ID. That way we don't wind up creating too big a PR.
Co-authored-by: Adrian Sutton <adrian@symphonious.net>
|
Hi @ajsutton, let me know if you have further comments on this. Meanwhile, I am preparing the PR for supporting chain ID as network ID. |
ajsutton
left a comment
There was a problem hiding this comment.
Sorry I lost track of what I'd said on this and was thinking we'd land the load-by-chain-id change first. But I'd said merge this and that probably does make more sense. I think it looks good so will get it merged in. The CI setup has changed a little in the mean time so I may have to jump a couple of hurdles but we'll get there. :)
* feat: op-program supports custom chain config * address comments * address comments * update mainnet.go/sepolia.go * Update op-program/chainconfig/chaincfg.go Co-authored-by: Adrian Sutton <adrian@symphonious.net> * more error info on config file not found --------- Co-authored-by: Qi Zhou <qizhou@ethstorage.io> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
* feat: op-program supports custom chain config * address comments * address comments * update mainnet.go/sepolia.go * Update op-program/chainconfig/chaincfg.go Co-authored-by: Adrian Sutton <adrian@symphonious.net> * more error info on config file not found --------- Co-authored-by: Qi Zhou <qizhou@ethstorage.io> Co-authored-by: Adrian Sutton <adrian@symphonious.net>
Description
This PR enables custom chain config in
op-program-clientto be part of the target binary (MIPS, RISCV64, etc) usinggo:embed. As a result, such custom config will be reflected in the absolute prestate hash, and thus be applied to the on-chain FDG.Tests
After spinning up a devnet via
make devnet-up, passmake verify-devnetunderop-programfolder.Additional context
See https://discord.com/channels/1244729134312198194/1290708296939999242/1291598392853790752
Metadata