Skip to content

chore(ci): Skip check files job on push events#1231

Merged
snario merged 1 commit intodevelopfrom
maurelian/fix-skip-codecov
Jul 7, 2021
Merged

chore(ci): Skip check files job on push events#1231
snario merged 1 commit intodevelopfrom
maurelian/fix-skip-codecov

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

@maurelian maurelian commented Jul 7, 2021

The recently added (#1209) GHA job which skips test-coverage when files are unchanged in packages/contracts causes a CI error when the event is a push.

This causes issues for maintainers who want to fix conflicts locally and push to a release branch.

This PR fixes that.
To be safe, I tested that it will still run the jobs when a push is made to an active PR.

  • Fixes OP-679

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 7, 2021

⚠️ No Changeset found

Latest commit: e0dc5f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@snario snario merged commit 8a8c709 into develop Jul 7, 2021
@snario snario deleted the maurelian/fix-skip-codecov branch July 7, 2021 17:19
theochap pushed a commit that referenced this pull request Dec 10, 2025
Co-authored-by: refcell <abigger87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants