Conversation
Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12256 +/- ##
===========================================
+ Coverage 71.99% 72.00% +0.01%
===========================================
Files 50 50
Lines 3910 3912 +2
===========================================
+ Hits 2815 2817 +2
Misses 910 910
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Inphi
commented
Oct 2, 2024
mbaxter
approved these changes
Oct 2, 2024
protolambda
pushed a commit
that referenced
this pull request
Oct 7, 2024
* cannon: Define 64-bit syscalls Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon * update semver-lock
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* cannon: Define 64-bit syscalls Also add SYS_FSTAT to the list of no-op syscalls emulated by MT-Cannon * update semver-lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SYS_FSTAT on Linux/MIPS64 is equivalent to SYS_FSTAT64 on Linux/MIPS32. So the 64-bit VM similarly emulates
SYS_FSTATas a no-op syscall.Fixes #12245