Merged
Conversation
packages/contracts-bedrock/src/L1/interfaces/ISystemConfigInterop.sol
Outdated
Show resolved
Hide resolved
Contributor
smartcontracts
left a comment
There was a problem hiding this comment.
Looking really good, since this touches OPCM I'm going to request that @mds1 leave the final approval
maurelian
reviewed
Oct 1, 2024
maurelian
reviewed
Oct 1, 2024
Contributor
|
Semgrep found 8
No Semgrep found 3
Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code. Ignore this finding from dangerous-exec-command. |
maurelian
approved these changes
Oct 1, 2024
Contributor
maurelian
left a comment
There was a problem hiding this comment.
LGTM assuming checks pass.
fdbe4b5 to
8177dbf
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* use interfaces in opcm contracts * fix change * fix encodeConstructor omission * fix wrong interface usage * fix change * fix change * remove commented fn * fix semver conflict issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the OPCM contracts to use interfaces and DeployUtils for contract deployments and contract type casting.