Interop: Update Inputs (rebased)#12204
Merged
protolambda merged 7 commits intodevelopfrom Oct 8, 2024
Merged
Conversation
9401c1e to
0ff61f1
Compare
0ff61f1 to
5dcf4e6
Compare
5dcf4e6 to
7681290
Compare
Contributor
|
Edited the |
b8e7b6e to
2122e1a
Compare
Contributor
|
Fixed a test that still relied on the old RPC, and dropped a TODO from code for which I opened an issue: #12357 |
protolambda
approved these changes
Oct 7, 2024
Contributor
|
Semgrep found 4
Named return arguments to functions must be appended with an underscore ( Semgrep found 2
Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 22
Inputs to functions must be prepended with an underscore ( |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* op-node,op-supervisor: feed local-unsafe/local-safe/l1-finalized data to supervisor * op-node,op-service,op-e2e: wip, fix interop op-node tests * post-rebase compilation fixes * BlockRef * op-supervisor: fix service test, cleanup todo * op-supervisor: link TODO comments to issue * interop: fix e2e action test --------- Co-authored-by: protolambda <proto@protolambda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a recreation of
#12094
but I didn't want to potentially mess up proto's original branch with bad rebase choices.
I pulled in develop and used the
-X theirsstrategy, and then usedrebase -ito remove all the redundant commits that were stuck in the PR. I looked over the PR and compared to thegit diff HEAD~~and it looks like it correctly removed just the parts that already got merged. But if I got that wrong, I can move back to the original branch.