Conversation
🦋 Changeset detectedLatest commit: 56deb61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## regenesis/0.5.0 #1190 +/- ##
===================================================
+ Coverage 86.18% 86.20% +0.02%
===================================================
Files 50 50
Lines 1990 1993 +3
Branches 318 318
===================================================
+ Hits 1715 1718 +3
Misses 275 275
Continue to review full report at Codecov.
|
a580e63 to
2c05762
Compare
smartcontracts
left a comment
There was a problem hiding this comment.
Requesting one minor change but otherwise LGTM.
packages/contracts/contracts/optimistic-ethereum/OVM/predeploys/OVM_GasPriceOracle.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/optimistic-ethereum/iOVM/predeploys/iOVM_GasPriceOracle.sol
Outdated
Show resolved
Hide resolved
2c05762 to
56deb61
Compare
Previously the `OVM_GasPriceOracle` did not emit an event when the gas price was updated. This is bad because it is hard to tell the historical changes in the smart contract state. With this change, it should be possible for a user to reconstruct the entire history of the changes in L2 gas prices based on the append only log data structure of the set of events. The event is `GasPriceUpdated(uint256,uint265)` where the first value is the old price and the second value is the new price. The ABI is also updated, changing the `gasPrice()(uint256)` getter into `getGasPrice()(uint265)` by making `gasPrice` be internal. Previously it was public so a getter was autogenerated.
|
This will require an update to the |
Description
Previously the
OVM_GasPriceOracledid not emit an event when the gasprice was updated. This is bad because it is hard to tell the historical
changes in the smart contract state. With this change, it should be
possible for a user to reconstruct the entire history of the changes in
L2 gas prices based on the append only log data structure of the set of
events.
The event is
GasPriceUpdated(uint256,uint265)where the first valueis the old price and the second value is the new price.
The ABI is also updated, changing the
gasPrice()(uint256)getter intogetGasPrice()(uint265)by makinggasPricebe internal. Previouslyit was public so a getter was autogenerated.