feat: sendRawTranscationConditional op-e2e test#11671
Merged
hamdiallam merged 3 commits intodevelopfrom Oct 9, 2024
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hamdiallam and the rest of your teammates on |
Merged
1 task
c56b5f9 to
740e21b
Compare
protolambda
reviewed
Sep 11, 2024
740e21b to
753eacf
Compare
95dde60 to
26f631c
Compare
753eacf to
3ec7222
Compare
26f631c to
1691a15
Compare
3ec7222 to
48486f0
Compare
48486f0 to
c3671c9
Compare
c3671c9 to
a8790fd
Compare
Contributor
|
Semgrep found 1 Prefer |
Contributor
Author
|
@protolambda @tynes soft bump |
tynes
approved these changes
Oct 9, 2024
Contributor
tynes
left a comment
There was a problem hiding this comment.
Given there are unit tests for the validity conditions being applied themselves, this covers sending and forwarding thru the RPC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Adds an op-e2e test for the SendRawTransactionConditional endpoint.
Monorepo was fitting as we dont have e2e tests for feature in op-geth and the txproxy is a supplemental/external service to this endpoint tested separately for what it does. The monorepo e2e tests op-geth pathways hence placing it here
tests pass locally (just waiting for a tagged release of op-geth to update the monorepo with)