Skip to content

fix(ci-builder): Build foundry from source#10180

Merged
tynes merged 2 commits into
developfrom
cl/ci-builder-fix
Apr 16, 2024
Merged

fix(ci-builder): Build foundry from source#10180
tynes merged 2 commits into
developfrom
cl/ci-builder-fix

Conversation

@clabby

@clabby clabby commented Apr 16, 2024

Copy link
Copy Markdown
Contributor

Overview

Fixes ci-builder's ability to compile foundry from source when need be. Previously, we used foundryup, which set RUSTFLAGS=-C target-cpu=native. This flag fell through to the host of the container, causing invalid instruction errors. Instead, we just build with cargo.

@clabby clabby requested review from a team and ajsutton April 16, 2024 22:32
@coderabbitai

coderabbitai Bot commented Apr 16, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate Limit Exceeded

@clabby has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 29 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 3fbb442 and e325897.

Walkthrough

The updates involve a downgrade of the base Debian image from bullseye-slim to buster-slim in the Dockerfile configurations for multiple build stages. Additionally, the process for installing Foundry has been altered to use a manual git checkout and specific binary builds, improving control over the installation process and potentially enhancing build stability and compatibility.

Changes

File Path Change Summary
ops/.../ci-builder/Dockerfile Updated base images from debian:bullseye-slim to debian:buster-slim. Modified commands for installing Foundry and stripping binaries.
ops/scripts/install-foundry.sh Changed Foundry installation from foundryup -C "$SHA" to git checkout $SHA and manual binary builds with cargo build.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@clabby Graphite App

clabby commented Apr 16, 2024

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

coderabbitai[bot]
coderabbitai Bot reviewed Apr 16, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread ops/scripts/install-foundry.sh Outdated
@clabby clabby force-pushed the cl/ci-builder-fix branch from 0978905 to 7f75f2a Compare April 16, 2024 22:36
@clabby clabby force-pushed the cl/ci-builder-fix branch from 7f75f2a to e325897 Compare April 16, 2024 22:40
@clabby clabby temporarily deployed to op-stack-production April 16, 2024 22:41 — with GitHub Actions Inactive
mds1
mds1 reviewed Apr 16, 2024
View reviewed changes
Comment thread ops/scripts/install-foundry.sh
@mds1 mds1 mentioned this pull request Apr 16, 2024
Merged
@tynes tynes enabled auto-merge April 16, 2024 23:14
@tynes tynes added this pull request to the merge queue Apr 16, 2024
Merged via the queue into develop with commit 126bb3f Apr 16, 2024
@tynes tynes deleted the cl/ci-builder-fix branch April 16, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mds1 mds1 mds1 left review comments

@ajsutton ajsutton ajsutton approved these changes

@tynes tynes tynes approved these changes

+1 more reviewer

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clabby @ajsutton @tynes @mds1