fix(docker-bake): prevent bash history expansion in metadata extraction#8
Merged
falcorocks merged 1 commit intomainfrom Dec 4, 2025
Merged
Conversation
Use quoted heredoc to safely write bake metadata to file before processing. This prevents bash history expansion issues when metadata contains special characters like '!' which can cause 'No such file or directory' errors. Fixes flaky CI failures observed in ethereum-optimism/optimism#18488
falcorocks
added a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 4, 2025
Updates docker-bake.yaml reference to include fix that prevents bash history expansion issues when build metadata contains special characters like '!'. Ref: ethereum-optimism/factory#8
github-merge-queue bot
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 4, 2025
…18498) Updates docker-bake.yaml reference to include fix that prevents bash history expansion issues when build metadata contains special characters like '!'. Ref: ethereum-optimism/factory#8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use quoted heredoc to safely write bake metadata to file before processing with jq. This prevents bash history expansion issues when metadata contains special characters like
!which can causeNo such file or directoryerrors.Problem
The original code:
echo '${{ steps.bake.outputs.metadata }}' | jq -r '...'Even with single quotes, bash history expansion (
!) is processed before quote parsing in some shell configurations. If the Docker build provenance metadata contained strings like!--..., bash would try to expand it as "last command starting with--".Solution
Use a quoted heredoc (
<<'DELIMITER') to write the metadata to a file first:The single quotes around the heredoc delimiter tell bash to treat the content as 100% literal - no variable expansion, no command substitution, no history expansion.
Related
Fixes flaky CI failures observed in ethereum-optimism/optimism#18488