Skip to content

EIP-7951: Precompile for secp256r1 Curve Support#31991

Merged
fjl merged 9 commits intoethereum:masterfrom
fjl:secp256r1-v2
Jul 7, 2025
Merged

EIP-7951: Precompile for secp256r1 Curve Support#31991
fjl merged 9 commits intoethereum:masterfrom
fjl:secp256r1-v2

Conversation

@fjl
Copy link
Copy Markdown
Contributor

@fjl fjl commented Jun 9, 2025

Comment thread crypto/secp256r1/verifier.go Outdated
Comment on lines 30 to 32
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check needed? Which part of the EIP does this correspond to?

I believe this check was not added in the RIP version, neither was it present in the implementation deployed in Scroll or OP.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the answer: ethereum-optimism/op-geth#168 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think we can get rid of it,

for more context, https://github.com/golang/go/blob/master/src/crypto/elliptic/nistec.go#L129-L134

@jwasinger jwasinger changed the title EIP-7951: Precompile for secp256r1 Curve Support EIP-7212: Precompile for secp256r1 Curve Support Jun 10, 2025
@alexb5dh
Copy link
Copy Markdown

Is this 7212 (which uses r' == r) or 7951 (r' == r [mod n])?

@jwasinger jwasinger changed the title EIP-7212: Precompile for secp256r1 Curve Support EIP-7951: Precompile for secp256r1 Curve Support Jun 10, 2025
@jwasinger
Copy link
Copy Markdown
Contributor

@alexb5dh I changed the title by mistake. Have corrected it now. This reflects EIP-7951

Comment on lines 1 to 9
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for preparing for the Fusaka! If you also consider implementing testdata, here is more extended version in a newer PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have updated the test vectors.

Comment thread params/protocol_params.go Outdated
@fjl
Copy link
Copy Markdown
Contributor Author

fjl commented Jul 7, 2025

@MariusVanDerWijden PTAL

Copy link
Copy Markdown
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit b3131f0 into ethereum:master Jul 7, 2025
5 of 8 checks passed
@fjl fjl added this to the 1.16.2 milestone Jul 7, 2025
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 11, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer added a commit to ava-labs/libevm that referenced this pull request Aug 12, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer pushed a commit to ava-labs/libevm that referenced this pull request Aug 13, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
JonathanOppenheimer pushed a commit to ava-labs/libevm that referenced this pull request Aug 13, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
howjmay pushed a commit to iotaledger/go-ethereum that referenced this pull request Aug 27, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
gballet pushed a commit to gballet/go-ethereum that referenced this pull request Sep 11, 2025
ethereum/EIPs#9833

Based on ethereum#27540, ethereum#30043

---------

Co-authored-by: Ulaş Erdoğan <uerdogan2001@hotmail.com>
ARR4N added a commit to ava-labs/libevm that referenced this pull request Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants