eth/protocols/eth: remove Requests in block body#30562
Merged
fjl merged 2 commits intoethereum:masterfrom Oct 10, 2024
Merged
Conversation
fjl
approved these changes
Oct 9, 2024
Member
|
I think we also need to remove the Otherwise the following diff will panic: |
Member
|
I think we also need to remove the |
Contributor
Author
It was removed in #30425 |
Member
|
Ah perfect, looks like I was on a wrong branch |
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
Block no longer has Requests. This PR just removes some code that wasn't removed in #30425.
This was referenced Dec 6, 2024
jakub-freebit
pushed a commit
to fblch/go-ethereum
that referenced
this pull request
Jul 3, 2025
Block no longer has Requests. This PR just removes some code that wasn't removed in ethereum#30425.
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
Block no longer has Requests. This PR just removes some code that wasn't removed in ethereum#30425.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block no longer has Requests.
It wasn't removed in #30425