Skip to content

feat(tests): EIP-8037 isolate intrinsic-regular > cap with floor < cap#2870

Merged
spencer-tb merged 2 commits into
ethereum:devnets/bal/7from
chfast:feat/eip-8037-isolated-cap-overflow
May 18, 2026
Merged

feat(tests): EIP-8037 isolate intrinsic-regular > cap with floor < cap#2870
spencer-tb merged 2 commits into
ethereum:devnets/bal/7from
chfast:feat/eip-8037-isolated-cap-overflow

Conversation

@chfast

@chfast chfast commented May 18, 2026

Copy link
Copy Markdown
Member

🗒️ Description

Add test_intrinsic_regular_gas_exceeds_cap_with_floor_below_cap covering the missing matrix cell in the EIP-7825/8037 cap-overflow fixtures: regular intrinsic exceeds the per-tx gas cap while the calldata floor stays well below it.

Constructed via 2,237 EIP-7702 authorizations (regular-only cost of PER_AUTH_BASE_COST=7500) plus 4 non-zero calldata bytes. A client that only checks max(regular, floor) against the cap would accept this tx; the EIP requires rejecting it.

🔗 Related Issues or PRs

Closes #2865.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added C-feat Category: an improvement or new feature P-urgent A-tests Area: Consensus tests. labels May 18, 2026
@spencer-tb spencer-tb self-assigned this May 18, 2026
@spencer-tb spencer-tb changed the base branch from eips/amsterdam/eip-8037 to devnets/bal/7 May 18, 2026 13:10
Add `test_intrinsic_regular_gas_exceeds_cap_with_floor_below_cap`
covering the missing matrix cell in the EIP-7825/8037 cap-overflow
fixtures: regular intrinsic exceeds the per-tx gas cap while the
calldata floor stays well below it.

Constructed via 2,237 EIP-7702 authorizations (regular-only cost
of PER_AUTH_BASE_COST=7500) plus 4 non-zero calldata bytes. A client
that only checks max(regular, floor) against the cap would accept
this tx; the EIP requires rejecting it.

Closes ethereum#2865.
@spencer-tb spencer-tb force-pushed the feat/eip-8037-isolated-cap-overflow branch from f3dab9e to 61c03c9 Compare May 18, 2026 13:14

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM!

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (devnets/bal/7@fdfb8b1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             devnets/bal/7    #2870   +/-   ##
================================================
  Coverage                 ?   87.39%           
================================================
  Files                    ?      586           
  Lines                    ?    35946           
  Branches                 ?     3381           
================================================
  Hits                     ?    31414           
  Misses                   ?     3911           
  Partials                 ?      621           
Flag Coverage Δ
unittests 87.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb merged commit a3e5201 into ethereum:devnets/bal/7 May 18, 2026
17 checks passed
spencer-tb pushed a commit to spencer-tb/execution-specs that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-feat Category: an improvement or new feature P-urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants