Skip to content

feat(spec-specs, tests): remove SD state gas refunds from EIP-8037#2845

Merged
fselmo merged 3 commits into
ethereum:devnets/bal/7from
spencer-tb:stb/eip-8037-remove-sd-state-refunds
May 12, 2026
Merged

feat(spec-specs, tests): remove SD state gas refunds from EIP-8037#2845
fselmo merged 3 commits into
ethereum:devnets/bal/7from
spencer-tb:stb/eip-8037-remove-sd-state-refunds

Conversation

@spencer-tb

@spencer-tb spencer-tb commented May 12, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

Remove all state gas refunds for SD in EIP-8037.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb spencer-tb requested review from fselmo and kclowes May 12, 2026 15:12
@spencer-tb spencer-tb added A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) C-feat Category: an improvement or new feature P-urgent A-tests Area: Consensus tests. labels May 12, 2026
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (devnets/bal/7@a0a1ed1). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             devnets/bal/7    #2845   +/-   ##
================================================
  Coverage                 ?   85.58%           
================================================
  Files                    ?      630           
  Lines                    ?    39593           
  Branches                 ?     3935           
================================================
  Hits                     ?    33887           
  Misses                   ?     5083           
  Partials                 ?      623           
Flag Coverage Δ
unittests 85.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fselmo fselmo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just did some tighter gas accounting to catch SD refund regression on a test 👍🏼

@fselmo fselmo merged commit 8148f2e into ethereum:devnets/bal/7 May 12, 2026
23 checks passed
spencer-tb added a commit to spencer-tb/execution-specs that referenced this pull request May 22, 2026
…thereum#2845)

* feat(spec): remove SD state gas refunds from EIP-8037

* feat(tests): invert SD state gas refund expectations for EIP-8037

* chore: a bit tighter gas accounting on selfdestruct test

---------

Co-authored-by: fselmo <fselmo2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) A-tests Area: Consensus tests. C-feat Category: an improvement or new feature P-urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants