feat(spec-specs, tests): EIP-8037 more refund fixes#2823
Merged
spencer-tb merged 6 commits intoMay 8, 2026
Merged
Conversation
4 tasks
165ba69 to
154ca13
Compare
12d6495 to
a3188a4
Compare
a3188a4 to
7897291
Compare
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devnets/bal/7 #2823 +/- ##
================================================
Coverage ? 85.58%
================================================
Files ? 630
Lines ? 39600
Branches ? 3936
================================================
Hits ? 33891
Misses ? 5084
Partials ? 625
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
lgtm! I extended the tests a bit and PR'd it here: spencer-tb#7 Lmk what you think, feel free to take or leave. Extended to more call opcodes, adds an intermediate revert test, and uses |
fselmo
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Lgtm, extended testing a bit here if you want to bring it in here before merging: spencer-tb#7
This was referenced May 7, 2026
fselmo
added a commit
to fselmo/execution-specs
that referenced
this pull request
May 8, 2026
fselmo
added a commit
to fselmo/execution-specs
that referenced
this pull request
May 8, 2026
fselmo
added a commit
to fselmo/execution-specs
that referenced
this pull request
May 8, 2026
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
May 22, 2026
Co-authored-by: felipe <fselmo2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Addresses 3 points for the EIP-8037
bal-devnet-7updates in #2804.Fixes creation tx halt/revert to correctly refund intrinsic state gas. A creation transaction that halts or reverts at the top level, now refunds the
STATE_BYTES_PER_NEW_ACCOUNT * COST_PER_STATE_BYTEportion of the intrinsic state gas back to the sender, since no contract account is ever created. The regular component of the intrinsic gas stays consumed -> ece6916Fixes a double charge of state gas on halt/revert. When an inline refund (SSTORE 0 to x to 0 or a CREATE silent failure) was applied inside a failing subcall, it was canceled at the failure boundary instead of being returned to the caller's reservoir, essentially charging the user twice, once for the original charge and again when the refund was dropped. Fixed for both same frame and cross frame variants -> b22aa09
Adds an explicit test for the creation tx address collision path, that verifies the intrinsic state gas refund flows through the address collision error path the same way it does on halt/revert -> 913827c
✅ Checklist
just statictype(scope):.